suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

a little method splitting action good times

Browse Source 
and high 5 @carlad
This commit is contained in:
Josh Kalderimis 2015-12-04 17:31:06 +01:00
parent 82f280f5d3
commit bbba45990d
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/travis/api/app/endpoint/authorization.rb
View File

@ -158,13 +158,15 @@ class Travis::Api::App
halt 403, "you are currently not allowed to perform this request. please contact support@travis-ci.com." halt 403, "you are currently not allowed to perform this request. please contact support@travis-ci.com."
end end
def check_first_login(user) # update first login date if not set
return unless Travis.config.customerio.site_id def update_first_login(user)
# update first login date if not set
unless user.first_logged_in_at unless user.first_logged_in_at
user.update_attributes(first_logged_in_at: Time.now) user.update_attributes(first_logged_in_at: Time.now)
end end
end
def update_customerio(user)
return unless Travis.config.customerio.site_id
# send event to customer.io # send event to customer.io
payload = { payload = {
@ -177,6 +179,7 @@ class Travis::Api::App
:education => user.education, :education => user.education,
:first_logged_in_at => user.first_logged_in_at.to_i :first_logged_in_at => user.first_logged_in_at.to_i
} }
customerio.identify(payload) customerio.identify(payload)
rescue StandardError => e rescue StandardError => e
Travis.logger.error "Could not update Customer.io for User: #{user.id}:#{user.login} with message:#{e.message}" Travis.logger.error "Could not update Customer.io for User: #{user.id}:#{user.login} with message:#{e.message}"
@ -211,7 +214,8 @@ class Travis::Api::App
user = user_for_github_token(github_token) user = user_for_github_token(github_token)
token = generate_token(user: user, app_id: 0) token = generate_token(user: user, app_id: 0)
payload = params[:state].split(":::", 2)[1] payload = params[:state].split(":::", 2)[1]
check_first_login(user) update_first_login(user)
update_customerio(user)
yield serialize_user(user), token, payload yield serialize_user(user), token, payload
else else
values[:state] = create_state values[:state] = create_state