From d1dd965b32ecfacabece2808e95641e4e57c7473 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steffen=20Ko=CC=88tte?= Date: Mon, 9 Nov 2015 12:51:07 +0100 Subject: [PATCH] fix permissions --- lib/travis/api/v3/permissions/cron.rb | 4 ---- lib/travis/api/v3/permissions/repository.rb | 4 ++++ lib/travis/api/v3/services/cron/delete.rb | 4 ++-- lib/travis/api/v3/services/crons/create.rb | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/travis/api/v3/permissions/cron.rb b/lib/travis/api/v3/permissions/cron.rb index 2db1f10c..815dd17c 100644 --- a/lib/travis/api/v3/permissions/cron.rb +++ b/lib/travis/api/v3/permissions/cron.rb @@ -5,9 +5,5 @@ module Travis::API::V3 def delete? write? end - - def create? - write? - end end end diff --git a/lib/travis/api/v3/permissions/repository.rb b/lib/travis/api/v3/permissions/repository.rb index 75f47597..53bfb9ae 100644 --- a/lib/travis/api/v3/permissions/repository.rb +++ b/lib/travis/api/v3/permissions/repository.rb @@ -13,5 +13,9 @@ module Travis::API::V3 def create_request? write? end + + def create_cron? + write? + end end end diff --git a/lib/travis/api/v3/services/cron/delete.rb b/lib/travis/api/v3/services/cron/delete.rb index 24753439..c5d9287d 100644 --- a/lib/travis/api/v3/services/cron/delete.rb +++ b/lib/travis/api/v3/services/cron/delete.rb @@ -4,9 +4,9 @@ module Travis::API::V3 def run! raise LoginRequired unless access_control.logged_in? or access_control.full_access? - + cron = find access_control.permissions(cron).delete! - find.destroy + cron.destroy end end end diff --git a/lib/travis/api/v3/services/crons/create.rb b/lib/travis/api/v3/services/crons/create.rb index d2a25089..0ec47ca1 100644 --- a/lib/travis/api/v3/services/crons/create.rb +++ b/lib/travis/api/v3/services/crons/create.rb @@ -5,7 +5,7 @@ module Travis::API::V3 def run! raise LoginRequired unless access_control.logged_in? or access_control.full_access? raise NotFound unless repository = find(:repository) - access_control.permissions(cron).create! + access_control.permissions(repository).create_cron! Models::Cron.create(repository: repository) end