From ddc6a3704e24e91aed08bc2244da28a9c6688eef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Hendricksen?= Date: Tue, 23 Aug 2016 03:26:01 -0400 Subject: [PATCH] add a test that demonstrates the change to the query on this branch supports the old params and the new v3 namespace params, and add the dirty flag for json column updates --- lib/travis/api/v3/models/settings.rb | 3 ++- spec/v3/services/settings_spec.rb | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/travis/api/v3/models/settings.rb b/lib/travis/api/v3/models/settings.rb index 0d3e4593..5c78c977 100644 --- a/lib/travis/api/v3/models/settings.rb +++ b/lib/travis/api/v3/models/settings.rb @@ -11,7 +11,8 @@ module Travis::API::V3 end def update(settings = {}) - repository.user_settings.update(settings) + repository.settings = repository.user_settings.update(settings).to_json + repository.settings_will_change! repository.save! end end diff --git a/spec/v3/services/settings_spec.rb b/spec/v3/services/settings_spec.rb index 11b839b5..e1798401 100644 --- a/spec/v3/services/settings_spec.rb +++ b/spec/v3/services/settings_spec.rb @@ -91,7 +91,7 @@ describe Travis::API::V3::Services::Settings, set_app: true do end describe 'authenticated, existing repo' do - let(:params) { JSON.dump('settings.build_pushes' => false) } + let(:params) { JSON.dump('settings.build_pushes' => false, 'maximum_number_of_builds' => 4) } before do repo.update_attributes(settings: JSON.dump('maximum_number_of_builds' => 20)) @@ -105,8 +105,9 @@ describe Travis::API::V3::Services::Settings, set_app: true do 'builds_only_with_travis_yml' => false, 'build_pushes' => false, 'build_pull_requests' => true, - 'maximum_number_of_builds' => 20 + 'maximum_number_of_builds' => 4 ) + expect(repo.reload.user_settings.maximum_number_of_builds).to eq(4) end end end