test result images based on the content-disposition header, fix content-disposition header

Gemfile.lock

@@ -51,7 +51,7 @@ GIT
 
 GIT
   remote: git://github.com/travis-ci/travis-core.git
-  revision: 714090635924650998b3a3d0f18b39d9cfd46839
+  revision: 751da684a3c44b2c493ebc41e9b38ff8edd5cef8
   specs:
     travis-core (0.0.1)
       actionmailer (~> 3.2.3)

lib/travis/api/app/responders/image.rb

@@ -6,7 +6,8 @@ module Travis::Api::App::Responders
 
     def apply
       headers['Expires'] = Time.now.utc.httpdate
-      halt send_file(filename, type: :png, disposition: :inline)
+      headers['Content-Disposition'] = %(inline; filename="#{File.basename(filename)}")
+      halt send_file(filename, type: :png)
     end
 
     private

spec/support/matchers.rb

@@ -26,22 +26,11 @@ end
 
 RSpec::Matchers.define :deliver_result_image_for do |name|
   match do |response|
-    actual = files.detect do |name, content|
+    header = response.headers['content-disposition']
-      response.body.to_s.force_encoding('ascii') == content.to_s.force_encoding('ascii') # TODO ummmmmmmm?
-    end
-    actual = actual && actual[0]
-
     failure_message_for_should do
-      "expected #{actual.inspect} to equal #{name.inspect}"
+      "expected #{response.env[:url].to_s} to return headers['content-disposition']  inline; filename=\"#{name}.png\" but it was: #{header.inspect}"
     end
-
+    header.to_s.should =~ /^inline; filename="#{name}\.png"$/
-    actual == name
-  end
-
-  def files
-    files = Hash[*Dir['public/images/result/*.png'].map do |file|
-      [File.basename(file, '.png'), File.read(file)]
-    end.flatten]
   end
 end