diff --git a/spec/v3/services/cron/delete_spec.rb b/spec/v3/services/cron/delete_spec.rb index a39f8c0f..9db7c6b2 100644 --- a/spec/v3/services/cron/delete_spec.rb +++ b/spec/v3/services/cron/delete_spec.rb @@ -52,7 +52,7 @@ describe Travis::API::V3::Services::Cron::Delete do "permission" => "delete", "cron" => { "@type" => "cron", - "@href" => "/cron/#{cron.id}", + "@href" => "/v3/cron/#{cron.id}", "@representation" => "minimal", "id" => cron.id } }} diff --git a/spec/v3/services/crons/create_spec.rb b/spec/v3/services/crons/create_spec.rb new file mode 100644 index 00000000..311fbdd7 --- /dev/null +++ b/spec/v3/services/crons/create_spec.rb @@ -0,0 +1,75 @@ +require 'spec_helper' + +describe Travis::API::V3::Services::Crons::Create do + let(:repo) { Travis::API::V3::Models::Repository.where(owner_name: 'svenfuchs', name: 'minimal').first } + let(:last_cron) {Travis::API::V3::Models::Cron.where(repository_id: repo.id).last} + let(:current_cron) {Travis::API::V3::Models::Cron.where(repository_id: repo.id).last} + let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } + let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} + let(:parsed_body) { JSON.load(body) } + + describe "creating a cron job" do + before { last_cron } + before { Travis::API::V3::Models::Permission.create(repository: repo, user: repo.owner, push: true) } + before { post("/v3/repo/#{repo.id}/crons/create", {}, headers) } + example { expect(current_cron == last_cron).to be_falsey } + example { expect(last_response).to be_ok } + example { expect(parsed_body).to be == { + "@type" => "cron", + "@href" => "/v3/cron/#{current_cron.id}", + "@representation" => "standard", + "@permissions" => { + "read" => true, + "delete" => true }, + "id" => current_cron.id, + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/#{repo.id}", + "@representation" => "minimal", + "id" => repo.id, + "name" => "minimal", + "slug" => "svenfuchs/minimal" } + }} + end + + describe "try creating a cron job without login" do + before { post("/v3/repo/#{repo.id}/crons/create") } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "login_required", + "error_message" => "login required" + }} + end + + describe "try creating a cron job with a user without permissions" do + before { Travis::API::V3::Models::Permission.create(repository: repo, user: repo.owner, push: false) } + before { post("/v3/repo/#{repo.id}/crons/create", {}, headers) } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "insufficient_access", + "error_message" => "operation requires create_cron access to repository", + "resource_type" => "repository", + "permission" => "create_cron", + "repository" => { + "@type" => "repository", + "@href" => "/v3/repo/#{repo.id}", + "@representation" => "minimal", + "id" => repo.id, + "name" => "minimal", + "slug" => "svenfuchs/minimal" } + }} + end + + describe "creating cron on a non-existing repository by slug" do + before { Travis::API::V3::Models::Permission.create(repository: repo, user: repo.owner, push: false) } + before { post("/v3/repo/svenfuchs%2Fminimal1/crons/create", {}, headers) } + example { expect(last_response).to be_not_found } + example { expect(parsed_body).to be == { + "@type" => "error", + "error_type" => "not_found", + "error_message" => "repository not found (or insufficient access)", + "resource_type" => "repository" + }} + end + +end