suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move settings to top level of response

Browse Source 
To better accommodate nested responses.
This commit is contained in:
Joe Corcoran 2016-06-08 17:18:24 +02:00
parent daf534edb7
commit eb0eab5967
2 changed files with 14 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/travis/api/v3/renderer/settings.rb
View File

@ -9,10 +9,8 @@ module Travis::API::V3
end
def render(settings, **)
{
:@type => 'settings'.freeze,
:settings => settings.to_h
}
response = { '@type' => 'settings'.freeze }
response.merge(settings.to_h)
end
end
end

30
spec/v3/services/settings_spec.rb
View File

@ -40,12 +40,10 @@ describe Travis::API::V3::Services::Settings do
example do
expect(JSON.load(body)).to eq(
'@type' => 'settings',
'settings' => {
'builds_only_with_travis_yml' => false,
'build_pushes' => true,
'build_pull_requests' => true,
'maximum_number_of_builds' => 0
}
'builds_only_with_travis_yml' => false,
'build_pushes' => true,
'build_pull_requests' => true,
'maximum_number_of_builds' => 0
)
end
end
@ -60,12 +58,10 @@ describe Travis::API::V3::Services::Settings do
example do
expect(JSON.load(body)).to eq(
'@type' => 'settings',
'settings' => {
'builds_only_with_travis_yml' => false,
'build_pushes' => false,
'build_pull_requests' => true,
'maximum_number_of_builds' => 0
}
'builds_only_with_travis_yml' => false,
'build_pushes' => false,
'build_pull_requests' => true,
'maximum_number_of_builds' => 0
)
end
end
@ -115,12 +111,10 @@ describe Travis::API::V3::Services::Settings do
example do
expect(JSON.load(body)).to eq(
'@type' => 'settings',
'settings' => {
'builds_only_with_travis_yml' => false,
'build_pushes' => false,
'build_pull_requests' => true,
'maximum_number_of_builds' => 20
}
'builds_only_with_travis_yml' => false,
'build_pushes' => false,
'build_pull_requests' => true,
'maximum_number_of_builds' => 20
)
end
end