suzanne.soy/travis-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v3: avoid N+1 queries when eager loading repository relations

Browse Source
This commit is contained in:
Konstantin Haase 2015-03-10 15:59:04 +01:00
parent 0f6b02b339
commit eb88cf6a2a
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/travis/api/v3/queries/repositories.rb
View File

@ -11,7 +11,9 @@ module Travis::API::V3
all = Models::Repository all = Models::Repository
all = all.where(active: bool(active)) unless active.nil? all = all.where(active: bool(active)) unless active.nil?
all = all.where(private: bool(private)) unless private.nil? all = all.where(private: bool(private)) unless private.nil?
all = all.includes(:default_branch) # TODO: use includes params all = all.includes(:owner) if includes? 'repository.owner'.freeze
all = all.includes(:last_build) if includes? 'repository.last_build'.freeze
all = all.includes(:default_branch)
all all
end end
end end

5
lib/travis/api/v3/query.rb
View File

@ -40,6 +40,11 @@ module Travis::API::V3
::Sidekiq::Client.push('queue'.freeze => queue, 'class'.freeze => class_name, 'args'.freeze => args) ::Sidekiq::Client.push('queue'.freeze => queue, 'class'.freeze => class_name, 'args'.freeze => args)
end end
def includes?(key)
@includes ||= @params['include'.freeze].to_s.split(?,.freeze)
@includes.include? key
end
def bool(value) def bool(value)
return false if value == 'false'.freeze return false if value == 'false'.freeze
!!value !!value