Commit Graph

2162 Commits

Author SHA1 Message Date
Igor
ff7d1dbfdd Merge pull request #290 from travis-ci/igor-update-rack-attack
Update rack-attack to 5.0.0.beta1
2016-07-05 13:11:59 +02:00
Igor
237f270708 Merge pull request #289 from travis-ci/igor-safelist-github-ips
safelist github IP range in Rack::Attack
2016-07-05 13:11:19 +02:00
Igor Wiedler
50b78a1458 Merge branch 'igor-safelist-github-ips' into igor-update-rack-attack 2016-07-05 13:03:05 +02:00
Igor Wiedler
79c14d697e only create/allocate GitHub CIDR object once 2016-07-05 13:02:00 +02:00
Igor Wiedler
d84d3983b8 update rack-attack to 5.0.0.beta1, use safelist/blocklist terminology 2016-07-05 12:58:58 +02:00
Igor Wiedler
a210cf8661 support nil ip 2016-07-05 12:46:32 +02:00
Igor Wiedler
0d90c21dbd require netaddr instead of cidr 2016-07-05 12:39:44 +02:00
Igor Wiedler
7e8b65a311 correct test case for GitHub IP check 2016-07-05 12:39:32 +02:00
Igor Wiedler
e6d7607916 safelist github IP range in Rack::Attack 2016-07-05 12:30:10 +02:00
Konstantin Haase
c1de919852 Don't run Rack::Attack for Enterprise. (#287)
On enterprise, the reverse proxy is not correctly set up, and therefore the client IP address not passed through properly. For that reason, all requests look like they originate from the same client, and if one gets blocked, everyone gets blocked.
2016-07-05 11:46:33 +02:00
Renée Hendricksen
7d52b06533 Merge branch 'jc-v3-env-vars' of github.com:travis-ci/travis-api into jc-v3-env-vars 2016-07-01 23:56:09 -04:00
Joe Corcoran
829366a554 Fix duplicate lines from rebase 2016-07-01 23:55:49 -04:00
Joe Corcoran
4b14f17cc5 Fix service specs 2016-07-01 23:55:49 -04:00
Joe Corcoran
f5bc526f25 Refactor repeated pattern into extracted method
Seems like we'll be checking login status before finding a resource
a lot, so here's a standard way to do it.
2016-07-01 23:55:49 -04:00
Joe Corcoran
1a07e199b5 Better style in error handling 2016-07-01 23:55:49 -04:00
Joe Corcoran
91e9fcebf7 Remove some duplication 2016-07-01 23:55:49 -04:00
Joe Corcoran
871b915515 Add env vars endpoints
This adds API V3 endpoints for querying, creating, modifying and
deleting environment variables.

It has no concept of encryption yet and should be considered a work in
progress.

We should also talk about the slightly off-track approach in the
EnvVars::Create service – maybe there's a way to standardise the
querying and rendering for post requests?

2016-07-01 23:55:49 -04:00
Joe Corcoran
77dcdaa482 Use travis-settings to manage JSON settings field
Since we use repository.settings as a kind of dump for all
sorts of settings, some user-facing and some not, this lets us
leave the db as it is, but pretend to have separate models for each
"kind" of setting.
2016-07-01 23:55:49 -04:00
Sven Fuchs
09806a5f93 Merge pull request #285 from travis-ci/igor-deprecate-event-notify
Add deprecation notice to Event.notify() that writes to log
2016-07-01 17:55:46 +02:00
Igor Wiedler
b5fe8f1884 Add deprecation notice to Event.notify() that writes to log 2016-07-01 17:48:34 +02:00
Igor
b9d65ff30f Merge pull request #284 from travis-ci/igor-fix-rate-limit
no longer test against user agent for github rate-limit, since it is not consistently github-camo
2016-07-01 16:39:02 +02:00
Igor Wiedler
34fbfc2ccf no longer test against user agent for github rate-limit, since it is not consistently github-camo 2016-07-01 16:27:41 +02:00
Joe Corcoran
bed317b109 Merge pull request #281 from travis-ci/igor-github-rate-limit
safelist build status image requests coming from github
2016-06-30 15:31:57 +02:00
Igor Wiedler
0156671fc8 safelist build status image requests coming from github
Currently almost all calls against API are being rate limited, including
build status images. This leads to common requesters such as GitHub's
camo proxy to get rate limited and receive a 429 response code.

This patch attempts to allow those requests.
2016-06-29 10:53:27 +02:00
Igor Wiedler
1f56dcc645 replace WHITELIST terminology with SAFELIST 2016-06-29 10:53:27 +02:00
Ana Rosas
14625ff7cb Merge pull request #282 from travis-ci/ar-add-enabled-for-all-flag
Add enable_for_all? condition on restart and cancel endpoints
2016-06-28 12:27:02 -07:00
Ana Rosas
69f0a9d33e Add enable_for_all? condition 2016-06-28 11:35:47 -07:00
Ana Rosas
0e5aa2fb7a Merge pull request #280 from travis-ci/ar-improve-feature-flag
[feature flag] Check for repository owner instead of current user
2016-06-24 13:32:26 -05:00
Ana Rosas
bfb68bf931 Merge branch 'master' into ar-improve-feature-flag 2016-06-23 17:07:36 -05:00
Ana Rosas
69cc2eef7d Check for repository owner instead of current user to validate feature flag 2016-06-23 15:15:31 -05:00
Piotr Sarnacki
16a7da54c2 Merge pull request #278 from travis-ci/ps-more-current-build-work
More `current_build` work
2016-06-23 10:05:55 +02:00
Joe Corcoran
0aeec35935 Fix duplicate lines from rebase 2016-06-22 16:59:49 +02:00
Joe Corcoran
769ae71076 Fix service specs 2016-06-22 16:50:11 +02:00
Piotr Sarnacki
32dd8d9f93 Mark current_build as experimental 2016-06-22 14:19:31 +02:00
Piotr Sarnacki
fcb0e7cde4 Rename current_build_id sort option to current_build 2016-06-22 14:19:31 +02:00
Joe Corcoran
88d9000042 Refactor repeated pattern into extracted method
Seems like we'll be checking login status before finding a resource
a lot, so here's a standard way to do it.
2016-06-21 15:34:11 +02:00
Joe Corcoran
81e93ca710 Better style in error handling 2016-06-21 15:34:11 +02:00
Joe Corcoran
00fb01bd7a Remove some duplication 2016-06-21 15:34:11 +02:00
Joe Corcoran
cae6da540f Add env vars endpoints
This adds API V3 endpoints for querying, creating, modifying and
deleting environment variables.

It has no concept of encryption yet and should be considered a work in
progress.

We should also talk about the slightly off-track approach in the
EnvVars::Create service – maybe there's a way to standardise the
querying and rendering for post requests?

2016-06-21 15:34:11 +02:00
Joe Corcoran
026dc4cb98 Use travis-settings to manage JSON settings field
Since we use repository.settings as a kind of dump for all
sorts of settings, some user-facing and some not, this lets us
leave the db as it is, but pretend to have separate models for each
"kind" of setting.
2016-06-21 15:33:05 +02:00
Sven Fuchs
cf5ea374d4 Merge pull request #277 from travis-ci/sf-cleanup-core
cleanup core
2016-06-21 15:28:39 +02:00
Sven Fuchs
dc176e0c0e remove commented callback code 2016-06-21 15:20:24 +02:00
Sven Fuchs
25f74defe5 try fixing updating github oauth scopes 2016-06-21 14:00:04 +02:00
Sven Fuchs
7250656de0 fix event notification 2016-06-21 12:16:43 +02:00
Sven Fuchs
6603990fe4 trigger sync in the auth endpoint, not the user model 2016-06-20 16:59:55 +02:00
Sven Fuchs
da4c7f26e6 fix auth endpoint 2016-06-20 15:04:38 +02:00
Sven Fuchs
060dd8aced delete github/find_or_create[org|repo|user] services 2016-06-20 11:26:47 +02:00
Sven Fuchs
84ebb6b24e move tracking github oauth scopes out of the user model, and into Travis::Github::Oauth 2016-06-19 17:33:03 +02:00
Sven Fuchs
734a7b9566 use travis-settings, remove travis/settings 2016-06-19 16:07:06 +02:00
Sven Fuchs
eb78d9df30 remove overwritable_method_definitions 2016-06-19 15:51:41 +02:00