From 1a0d004aeb79b5bf2079b354c3926c913b596f26 Mon Sep 17 00:00:00 2001
From: Piotr Sarnacki <drogus@gmail.com>
Date: Thu, 8 May 2014 14:34:05 +0200
Subject: [PATCH] Link commit on requests list to github
---
assets/scripts/app/helpers/handlebars.coffee | 9 +++++++++
assets/scripts/app/models/request.coffee | 2 +-
assets/scripts/app/templates/requests.hbs | 2 +-
assets/styles/app.sass | 10 ++++++++++
4 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/assets/scripts/app/helpers/handlebars.coffee b/assets/scripts/app/helpers/handlebars.coffee
index 06944266..2c09186d 100644
--- a/assets/scripts/app/helpers/handlebars.coffee
+++ b/assets/scripts/app/helpers/handlebars.coffee
@@ -309,6 +309,15 @@ Ember.registerBoundHelper 'capitalize', (value, options) ->
else
''
+Ember.Handlebars.helper('githubCommitLink', (slug, commitSha) ->
+ return '' unless commitSha
+ sha = Handlebars.Utils.escapeExpression Travis.Helpers.formatCommit(commitSha)
+ return sha unless slug
+ url = Handlebars.Utils.escapeExpression Travis.Urls.githubCommit(slug, sha)
+
+ safe '<a class="github-link only-on-hover" href="' + url + '">' + sha + '</a>'
+)
+
Ember.registerBoundHelper 'formatTime', (value, options) ->
safe Travis.Helpers.timeAgoInWords(value) || '-'
diff --git a/assets/scripts/app/models/request.coffee b/assets/scripts/app/models/request.coffee
index 4b23c1b3..6f238a05 100644
--- a/assets/scripts/app/models/request.coffee
+++ b/assets/scripts/app/models/request.coffee
@@ -14,7 +14,7 @@ require 'travis/model'
pullRequestTitle: Ember.attr('string')
pullRequestNumber: Ember.attr(Number)
- repo: Ember.belongsTo('Travis.Request', key: 'repository_id')
+ repo: Ember.belongsTo('Travis.Repo', key: 'repository_id')
commit: Ember.belongsTo('Travis.Commit', key: 'commit_id')
build: Ember.belongsTo('Travis.Build', key: 'build_id')
diff --git a/assets/scripts/app/templates/requests.hbs b/assets/scripts/app/templates/requests.hbs
index 0b1c78f1..20d1445a 100644
--- a/assets/scripts/app/templates/requests.hbs
+++ b/assets/scripts/app/templates/requests.hbs
@@ -17,7 +17,7 @@
<span class="status"></span>
{{request.id}}
</td>
- <td>{{formatSha request.commit.sha}}</td>
+ <td>{{githubCommitLink request.repo.slug request.commit.sha}}</td>
<td>
{{#if build}}
{{#link-to "build" build}}#{{build.number}}{{/link-to}}
diff --git a/assets/styles/app.sass b/assets/styles/app.sass
index 2bc86a61..24cc1be4 100644
--- a/assets/styles/app.sass
+++ b/assets/styles/app.sass
@@ -21,3 +21,13 @@ ul
li
padding: 0
+.github-link
+ background: transparent url(/images/icons/github.png) center right no-repeat
+ background-size: 12px
+ opacity: 1
+ padding-right: 16px
+
+ &.only-on-hover
+ background-image: none
+ &.only-on-hover:hover
+ background-image: url(/images/icons/github.png)