From 20e8a4757610dc78858c13d854b109e1477ec757 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Thu, 11 Feb 2016 13:42:31 +0100 Subject: [PATCH] Fix logs displaying when a restart happens When a user restarts a job, we should not try fetching the log again. In order to do this I added a guard in job-log component, which checks if attributes changed in didReceiveAttrs callback. If the old job value is the same as the new value, we don't need to do anything. --- app/components/job-log.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/app/components/job-log.js b/app/components/job-log.js index c460dbf8..8ba81be4 100644 --- a/app/components/job-log.js +++ b/app/components/job-log.js @@ -6,12 +6,17 @@ export default Ember.Component.extend({ didReceiveAttrs: function(options) { this._super(...arguments); - if(options.oldAttrs && options.oldAttrs.job && options.oldAttrs.job.value) { - this.teardownLog(options.oldAttrs.job.value); - } + let oldJob = options.oldAttrs && options.oldAttrs.job && options.oldAttrs.job.value, + newJob = options.newAttrs && options.newAttrs.job && options.newAttrs.job.value; - if(options.newAttrs && options.newAttrs.job && options.newAttrs.job.value) { - this.setupLog(options.newAttrs.job.value); + if(newJob !== oldJob) { + if(newJob) { + this.setupLog(newJob); + } + + if(oldJob) { + this.teardownLog(oldJob); + } } },