suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use el.innerHTML = ''; instead of $(el).empty()

Browse Source 
It turns out that jQuery's empty method can be really slow in Firefox,
which can freeze the browser when cleaning the log.
This commit is contained in:
Piotr Sarnacki 2015-12-29 12:49:47 +01:00
parent 6e73923fbb
commit 21285bbe8b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/components/log-content.js
View File

@ -90,8 +90,8 @@ export default Ember.Component.extend({
if ((ref = this.lineSelector) != null) { if ((ref = this.lineSelector) != null) {
ref.willDestroy(); ref.willDestroy();
} }
if (logElement = this.$('#log')) { if (logElement = this.$('#log')[0]) {
return logElement.empty(); logElement.innerHTML = '';
} }
} }
}, },
@ -99,8 +99,8 @@ export default Ember.Component.extend({
createEngine(log) { createEngine(log) {
var logElement; var logElement;
if (log || (log = this.get('log'))) { if (log || (log = this.get('log'))) {
if (logElement = this.$('#log')) { if (logElement = this.$('#log')[0]) {
logElement.empty(); logElement.innerHTML = '';
} }
log.onClear(() => { log.onClear(() => {
this.teardownLog(); this.teardownLog();