From 24465e634ff15cc002a7571f150f727a1aa97542 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Fri, 29 Jan 2016 14:14:01 +0100 Subject: [PATCH] Use el.innerHTML = ''; instead of $(el).empty() innerHTML is faster than empty(), especially on some versions of firefox. This change was already commited before, but it was somehow lost while converting project to JS. --- app/components/log-content.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/app/components/log-content.js b/app/components/log-content.js index 33da53b5..ca0f832e 100644 --- a/app/components/log-content.js +++ b/app/components/log-content.js @@ -80,7 +80,7 @@ export default Ember.Component.extend({ }, teardownLog(log) { - var logElement, parts, ref; + var parts, ref; if (log || (log = this.get('log'))) { parts = log.get('parts'); parts.removeArrayObserver(this, { @@ -92,18 +92,20 @@ export default Ember.Component.extend({ if ((ref = this.lineSelector) != null) { ref.willDestroy(); } - if (logElement = this.$('#log')) { - return logElement.empty(); - } + this.clearLogElement(); + } + }, + + clearLogElement() { + var logElement = this.$('#log'); + if (logElement && logElement[0]) { + logElement[0].innerHTML = ''; } }, createEngine(log) { - var logElement; if (log || (log = this.get('log'))) { - if (logElement = this.$('#log')) { - logElement.empty(); - } + this.clearLogElement(); log.onClear(() => { this.teardownLog(); return this.createEngine();