From fc5e003be945de48ea53f42bccf914084b7f4e57 Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Tue, 7 Jul 2015 17:47:20 +0200 Subject: [PATCH 1/4] some preparation for no builds --- app/styles/app.scss | 1 + app/styles/app/layouts/missing-notice.sass | 8 ++++++++ app/templates/builds/not-found.hbs | 7 ++++++- 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 app/styles/app/layouts/missing-notice.sass diff --git a/app/styles/app.scss b/app/styles/app.scss index 764e55ba..dffd6596 100644 --- a/app/styles/app.scss +++ b/app/styles/app.scss @@ -57,3 +57,4 @@ @import "app/layouts/caches"; @import "app/layouts/getting-started"; @import "app/layouts/first-sync"; +@import "app/layouts/missing-notice"; diff --git a/app/styles/app/layouts/missing-notice.sass b/app/styles/app/layouts/missing-notice.sass new file mode 100644 index 00000000..497c9385 --- /dev/null +++ b/app/styles/app/layouts/missing-notice.sass @@ -0,0 +1,8 @@ +.missing-notice + text-align: center + +.page-title + color: #808080 + font-size: 36px + font-weight: 200 + line-height: 1 \ No newline at end of file diff --git a/app/templates/builds/not-found.hbs b/app/templates/builds/not-found.hbs index 7fbeea2e..ffb74ad3 100644 --- a/app/templates/builds/not-found.hbs +++ b/app/templates/builds/not-found.hbs @@ -1 +1,6 @@ -There are no builds for this repository. +
+ +

No builds for this repository

+

Want to start testing this project on Travis CI?

+ Trigger the first build +
From 0ab508a5dc2292dea10e70f9ab4ddc0bb905da0c Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Tue, 7 Jul 2015 21:17:59 +0200 Subject: [PATCH 2/4] style no build page --- app/styles/app/layouts/missing-notice.sass | 23 +++++++- app/styles/app/modules/buttons.sass | 1 + app/templates/builds/not-found.hbs | 61 +++++++++++++++++++++- public/images/svg/cones.svg | 57 ++++++++++++++++++++ 4 files changed, 138 insertions(+), 4 deletions(-) create mode 100644 public/images/svg/cones.svg diff --git a/app/styles/app/layouts/missing-notice.sass b/app/styles/app/layouts/missing-notice.sass index 497c9385..40c39963 100644 --- a/app/styles/app/layouts/missing-notice.sass +++ b/app/styles/app/layouts/missing-notice.sass @@ -1,8 +1,27 @@ .missing-notice text-align: center + a + font-size: 14px + .page-title - color: #808080 + color: #434343 font-size: 36px font-weight: 200 - line-height: 1 \ No newline at end of file + line-height: 1 + margin-bottom: .5em + +.page-notice + font-size: $font-size-m + color: #8d8d8d + +.page-graphic + width: 80% + height: auto + max-width: 310px + margin: 3.75rem auto 0 + padding: 0 2em + line-height: 0 + border-bottom: 1px solid #DEDCDB + @media #{$medium-up} + width: 32% diff --git a/app/styles/app/modules/buttons.sass b/app/styles/app/modules/buttons.sass index 4caac525..654b2f20 100644 --- a/app/styles/app/modules/buttons.sass +++ b/app/styles/app/modules/buttons.sass @@ -22,6 +22,7 @@ $button-border-color: #d4d4d4 text-align: center color: $gray-dark-3 white-space: nowrap + border-radius: 2px .button:hover, .button:focus, diff --git a/app/templates/builds/not-found.hbs b/app/templates/builds/not-found.hbs index ffb74ad3..35c85ad0 100644 --- a/app/templates/builds/not-found.hbs +++ b/app/templates/builds/not-found.hbs @@ -1,6 +1,63 @@
- +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + +
+

No builds for this repository

Want to start testing this project on Travis CI?

- Trigger the first build + Read the Docs on Getting Started
diff --git a/public/images/svg/cones.svg b/public/images/svg/cones.svg new file mode 100644 index 00000000..500ccbef --- /dev/null +++ b/public/images/svg/cones.svg @@ -0,0 +1,57 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 1d068fdfdee9be12376aab28c95e6ed59958ce39 Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Tue, 7 Jul 2015 21:38:42 +0200 Subject: [PATCH 3/4] make no builds a component and display it on all tabs --- app/components/no-builds.coffee | 5 ++ app/templates/builds.hbs | 3 + app/templates/builds/not-found.hbs | 64 +-------------------- app/templates/components/no-builds.hbs | 63 ++++++++++++++++++++ tests/unit/components/no-builds-test.coffee | 17 ++++++ 5 files changed, 89 insertions(+), 63 deletions(-) create mode 100644 app/components/no-builds.coffee create mode 100644 app/templates/components/no-builds.hbs create mode 100644 tests/unit/components/no-builds-test.coffee diff --git a/app/components/no-builds.coffee b/app/components/no-builds.coffee new file mode 100644 index 00000000..38e3b529 --- /dev/null +++ b/app/components/no-builds.coffee @@ -0,0 +1,5 @@ +`import Ember from 'ember'` + +NoBuildsComponent = Ember.Component.extend() + +`export default NoBuildsComponent` diff --git a/app/templates/builds.hbs b/app/templates/builds.hbs index ec885c71..e9cd7322 100644 --- a/app/templates/builds.hbs +++ b/app/templates/builds.hbs @@ -2,6 +2,8 @@ {{!-- --}} {{#each controller as |build|}} {{builds-item build=build}} + {{else}} + {{no-builds}} {{/each}} {{#if displayShowMoreButton}}

@@ -11,6 +13,7 @@ {{/if}}

{{/if}} + {{else}} {{loading-indicator}} {{/if}} diff --git a/app/templates/builds/not-found.hbs b/app/templates/builds/not-found.hbs index 35c85ad0..bd2b8add 100644 --- a/app/templates/builds/not-found.hbs +++ b/app/templates/builds/not-found.hbs @@ -1,63 +1 @@ -
-
- - - - - - - - - - - - - - - - - - - - - - - - - - - -
- -

No builds for this repository

-

Want to start testing this project on Travis CI?

- Read the Docs on Getting Started -
+{{no-builds}} \ No newline at end of file diff --git a/app/templates/components/no-builds.hbs b/app/templates/components/no-builds.hbs new file mode 100644 index 00000000..35c85ad0 --- /dev/null +++ b/app/templates/components/no-builds.hbs @@ -0,0 +1,63 @@ +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + +
+ +

No builds for this repository

+

Want to start testing this project on Travis CI?

+ Read the Docs on Getting Started +
diff --git a/tests/unit/components/no-builds-test.coffee b/tests/unit/components/no-builds-test.coffee new file mode 100644 index 00000000..c792f42a --- /dev/null +++ b/tests/unit/components/no-builds-test.coffee @@ -0,0 +1,17 @@ +`import { test, moduleForComponent } from 'ember-qunit'` + +moduleForComponent 'no-builds', { + # specify the other units that are required for this test + # needs: ['component:foo', 'helper:bar'] +} + +test 'it renders', (assert) -> + assert.expect 2 + + # creates the component instance + component = @subject() + assert.equal component._state, 'preRender' + + # renders the component to the page + @render() + assert.equal component._state, 'inDOM' From cbdd754c00f000d58d2a29f81d5498eeee8d8a1b Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Wed, 8 Jul 2015 13:14:38 +0200 Subject: [PATCH 4/4] move illustration down a bit --- app/styles/app/layouts/missing-notice.sass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/styles/app/layouts/missing-notice.sass b/app/styles/app/layouts/missing-notice.sass index 40c39963..d2ec8ed8 100644 --- a/app/styles/app/layouts/missing-notice.sass +++ b/app/styles/app/layouts/missing-notice.sass @@ -19,7 +19,7 @@ width: 80% height: auto max-width: 310px - margin: 3.75rem auto 0 + margin: 5.75rem auto 0 padding: 0 2em line-height: 0 border-bottom: 1px solid #DEDCDB