From 2882c8ca962f3718d0f7d5123a680eb36935cc21 Mon Sep 17 00:00:00 2001 From: Lisa P Date: Mon, 25 Jan 2016 15:25:33 +0100 Subject: [PATCH] add empty href otherwise iOS does not fire a tap event correctly --- app/components/log-content.js | 5 ++--- app/templates/components/log-content.hbs | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/components/log-content.js b/app/components/log-content.js index b21cfe6c..44e10692 100644 --- a/app/components/log-content.js +++ b/app/components/log-content.js @@ -60,6 +60,7 @@ Object.defineProperty(Log.Limit.prototype, 'limited', { export default Ember.Component.extend({ popup: Ember.inject.service(), + classNameBindings: ['logIsVisible:is-open'], logIsVisible: false, currentUserBinding: 'auth.currentUser', @@ -226,7 +227,5 @@ export default Ember.Component.extend({ toggleLog() { this.toggleProperty('logIsVisible'); } - }, - - noop() {} + } }); diff --git a/app/templates/components/log-content.hbs b/app/templates/components/log-content.hbs index 002aaf62..5dfed50c 100644 --- a/app/templates/components/log-content.hbs +++ b/app/templates/components/log-content.hbs @@ -27,13 +27,13 @@ {{#if job.notStarted}}
Hang tight, the log cannot be shown until the build has started.
{{else}} - + {{eye-icon}} View log