From 2ccade46a4cf4c380031374ed9c09992ec43f7b2 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Thu, 14 Aug 2014 22:10:11 +0200 Subject: [PATCH] Fix some of the issues with duration sometimes not showing up * duration was not actually defined in Travis.Job, which may have caused bugs when combined with partial record loading (so for example it was ok on a refresh, but may have been broken on update) * notStarted was not a dependency of duration --- assets/scripts/app/models/extensions.coffee | 2 +- assets/scripts/app/models/job.coffee | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/assets/scripts/app/models/extensions.coffee b/assets/scripts/app/models/extensions.coffee index e265ede8..de5cff0a 100644 --- a/assets/scripts/app/models/extensions.coffee +++ b/assets/scripts/app/models/extensions.coffee @@ -6,7 +6,7 @@ Travis.DurationCalculations = Ember.Mixin.create duration else Travis.Helpers.durationFrom(@get('startedAt'), @get('finishedAt')) - ).property('_duration', 'finishedAt', 'startedAt') + ).property('_duration', 'finishedAt', 'startedAt', 'notStarted') updateTimes: -> unless @get('isFinished') diff --git a/assets/scripts/app/models/job.coffee b/assets/scripts/app/models/job.coffee index 23649a37..6ceb04eb 100644 --- a/assets/scripts/app/models/job.coffee +++ b/assets/scripts/app/models/job.coffee @@ -21,6 +21,7 @@ require 'travis/model' annotations: Ember.hasMany('Travis.Annotation') _config: Ember.attr('object', key: 'config') + _duration: Ember.attr(Number, key: 'duration') log: ( -> @set('isLogAccessed', true)