From 345cb6e29e06dd87ab11e5464fe16af3a0e967e4 Mon Sep 17 00:00:00 2001
From: Piotr Sarnacki <drogus@gmail.com>
Date: Thu, 15 Jan 2015 17:02:32 +0100
Subject: [PATCH] Cleanup BuildView

---
 assets/scripts/app/controllers/build.coffee |  8 ++++++++
 assets/scripts/app/templates/build.hbs      |  6 +++---
 assets/scripts/app/views/build.coffee       | 10 ----------
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/assets/scripts/app/controllers/build.coffee b/assets/scripts/app/controllers/build.coffee
index c8763418..d5555b17 100644
--- a/assets/scripts/app/controllers/build.coffee
+++ b/assets/scripts/app/controllers/build.coffee
@@ -10,3 +10,11 @@ Travis.BuildController = Ember.Controller.extend Travis.GithubUrlProperties,
   loading: (->
     @get('build.isLoading')
   ).property('build.isLoading')
+
+  urlCommitterGravatarImage: (->
+    Travis.Urls.gravatarImage(@get('commit.committerEmail'), 40)
+  ).property('commit.committerEmail')
+
+  urlAuthorGravatarImage: (->
+    Travis.Urls.gravatarImage(@get('commit.authorEmail'), 40)
+  ).property('commit.authorEmail')
diff --git a/assets/scripts/app/templates/build.hbs b/assets/scripts/app/templates/build.hbs
index 88907014..ef6ef692 100644
--- a/assets/scripts/app/templates/build.hbs
+++ b/assets/scripts/app/templates/build.hbs
@@ -24,7 +24,7 @@
       {{/if}}
 
       <div class="commit-changes">
-        <a class="commit" {{bind-attr href="controller.urlGithubCommit"}}>Commit {{formatSha commit.sha}}</a>
+        <a class="commit" {{bind-attr href="urlGithubCommit"}}>Commit {{formatSha commit.sha}}</a>
       </div>
       <div class="commit-changes">
         {{#if build.pullRequest}}
@@ -52,11 +52,11 @@
     <div class="footer">
       <div class="author">
         {{#if commit.authorName}}
-          <div class="authored"><img {{bind-attr src="view.urlAuthorGravatarImage"}}/><div class="text">{{commit.authorName}} authored{{#if commit.authorIsCommitter}} and committed{{/if}}</div></div>
+          <div class="authored"><img {{bind-attr src="urlAuthorGravatarImage"}}/><div class="text">{{commit.authorName}} authored{{#if commit.authorIsCommitter}} and committed{{/if}}</div></div>
         {{/if}}
         {{#unless commit.authorIsCommitter}}
           {{#if commit.committerName}}
-            <div class="committed"><img {{bind-attr src="view.urlCommitterGravatarImage"}}/><div class="text">{{commit.committerName}} committed</div></div>
+            <div class="committed"><img {{bind-attr src="urlCommitterGravatarImage"}}/><div class="text">{{commit.committerName}} committed</div></div>
           {{/if}}
         {{/unless}}
       </div>
diff --git a/assets/scripts/app/views/build.coffee b/assets/scripts/app/views/build.coffee
index b375495f..2d2aae90 100644
--- a/assets/scripts/app/views/build.coffee
+++ b/assets/scripts/app/views/build.coffee
@@ -22,16 +22,6 @@ Travis.reopen
   BuildView: Travis.View.extend
     classNameBindings: ['color', 'loading']
     buildBinding: 'controller.build'
-    commitBinding: 'build.commit'
-
-    urlCommitterGravatarImage: (->
-      Travis.Urls.gravatarImage(@get('commit.committerEmail'), 40)
-    ).property('commit.committerEmail')
-
-    urlAuthorGravatarImage: (->
-      Travis.Urls.gravatarImage(@get('commit.authorEmail'), 40)
-    ).property('commit.authorEmail')
-
     loadingBinding: 'controller.loading'
 
     color: (->