diff --git a/assets/scripts/app/controllers.coffee b/assets/scripts/app/controllers.coffee index d0f4a672..48b2081f 100644 --- a/assets/scripts/app/controllers.coffee +++ b/assets/scripts/app/controllers.coffee @@ -9,6 +9,10 @@ Travis.BuildsItemController = Em.ObjectController.extend(Travis.GithubUrlPropert needs: ['builds'] isPullRequestsListBinding: 'controllers.builds.isPullRequestsList' buildBinding: 'content' + + color: (-> + Travis.Helpers.colorForState(@get('build.state')) + ).property('build.state') ) Travis.QueueController = Em.ArrayController.extend diff --git a/assets/scripts/app/templates/builds/list.hbs b/assets/scripts/app/templates/builds/list.hbs index 221b16eb..262ce55b 100644 --- a/assets/scripts/app/templates/builds/list.hbs +++ b/assets/scripts/app/templates/builds/list.hbs @@ -22,40 +22,40 @@ {{#each build in controller itemController="buildsItem"}} - {{#view Travis.BuildsItemView contextBinding="build"}} + - {{#if id}} - {{#link-to "build" repo this}} - {{number}} + {{#if build.id}} + {{#link-to "build" build.repo build}} + {{build.number}} {{/link-to}} {{/if}} - {{{formatMessage commit.message short="true" repoBinding=build.repo}}} + {{{formatMessage build.commit.message short="true" repoBinding=build.repo}}} - - {{formatCommit commit}} + + {{formatCommit build.commit}} - {{commit.committerName}} + {{build.commit.committerName}} {{#if isPullRequestsList}} - - #{{pullRequestNumber}} + + #{{build.pullRequestNumber}} {{/if}} - - {{formatDuration duration}} + + {{formatDuration build.duration}} - - {{formatTime finishedAt}} + + {{formatTime build.finishedAt}} - {{/view}} + {{/each}} diff --git a/assets/scripts/app/views/build.coffee b/assets/scripts/app/views/build.coffee index 58a464c9..b7b2940a 100644 --- a/assets/scripts/app/views/build.coffee +++ b/assets/scripts/app/views/build.coffee @@ -20,19 +20,6 @@ Travis.reopen click: -> @get('controller').showMore() - BuildsItemView: Travis.View.extend - tagName: 'tr' - classNameBindings: ['color'] - repoBinding: 'controller.repo' - buildBinding: 'context' - commitBinding: 'build.commit' - - isPullRequestsList: ( -> @get('parentView.isPullRequestsList') ).property('parentView.isPullRequestsList') - - color: (-> - Travis.Helpers.colorForState(@get('build.state')) - ).property('build.state') - BuildView: Travis.View.extend templateName: 'builds/show' classNameBindings: ['color', 'loading']