From 4b71704b1cde5aefca01fee4c6f425f0ba68186b Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Thu, 7 Jan 2016 11:16:13 +0100 Subject: [PATCH] [deprecations] Don't use second argument in a property This makes Ember.js think that we're trying to use the property as setter and it's deprecated --- app/components/env-var.js | 2 +- config/deprecation-workflow.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/components/env-var.js b/app/components/env-var.js index 92f935a6..6442130b 100644 --- a/app/components/env-var.js +++ b/app/components/env-var.js @@ -8,7 +8,7 @@ export default Ember.Component.extend({ actionType: 'Save', showValueField: Ember.computed.alias('public'), - value: function(key, value) { + value: function(key) { if (this.get('envVar.public')) { return this.get('envVar.value'); } else { diff --git a/config/deprecation-workflow.js b/config/deprecation-workflow.js index 8be959a8..0a30bccf 100644 --- a/config/deprecation-workflow.js +++ b/config/deprecation-workflow.js @@ -13,6 +13,7 @@ window.deprecationWorkflow.config = { { handler: "log", matchMessage: "RestAdapter#find has been deprecated and renamed to `findRecord`." }, { handler: "log", matchMessage: "Usage of `typeKey` has been deprecated and will be removed in Ember Data 2.0. It has been replaced by `modelName` on the model class." }, { handler: "log", matchMessage: "Using store.dematerializeRecord() has been deprecated since it was intended for private use only. You should use store.unloadRecord() instead." }, + { handler: "log", matchMessage: "Using the same function as getter and setter is deprecated." }, // TODO { handler: "silence", matchMessage: "Ember.View is deprecated. Consult the Deprecations Guide for a migration strategy." }, @@ -22,7 +23,6 @@ window.deprecationWorkflow.config = { { handler: "silence", matchMessage: "`Ember.ArrayController` is deprecated." }, { handler: "silence", matchMessage: "Ember.removeBeforeObserver is deprecated and will be removed in the near future." }, { handler: "silence", matchMessage: "The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in your adapter:application and return false." }, - { handler: "silence", matchMessage: "Using the same function as getter and setter is deprecated." }, { handler: "silence", matchMessage: "Using DS.Snapshot.get() is deprecated. Use .attr(), .belongsTo() or .hasMany() instead." }, ] };