From 4fc599f7677a203f347fc31f6ead6221f5406e1e Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Fri, 15 Aug 2014 06:03:28 +0200 Subject: [PATCH] Revert dd46161 and 2ccade4 Duration on job was not specified, beacuse we actually don't return duration from the API, it's always calculated based on startedAt and finishedAt, that's why it's obsolete. It doesn't hurt to have it defined on the Job model, but there's no need to do it. --- assets/scripts/app/models/job.coffee | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/assets/scripts/app/models/job.coffee b/assets/scripts/app/models/job.coffee index e6b147c5..23649a37 100644 --- a/assets/scripts/app/models/job.coffee +++ b/assets/scripts/app/models/job.coffee @@ -21,7 +21,6 @@ require 'travis/model' annotations: Ember.hasMany('Travis.Annotation') _config: Ember.attr('object', key: 'config') - _duration: Ember.attr(Number, key: 'duration') log: ( -> @set('isLogAccessed', true) @@ -108,7 +107,7 @@ require 'travis/model' ).observes('state') isPropertyLoaded: (key) -> - if ['_duration', '_finishedAt'].contains(key) && !@get('isFinished') + if ['_finishedAt'].contains(key) && !@get('isFinished') return true else if key == '_startedAt' && @get('state') == 'created' return true