suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix isAttributeLoaded checks

Browse Source 
We can't check 'isFinished' when model is asked for
isAttributeLoaded('state'). In such situation, it will go to isFinished
and call @get('state'), which will trigger isAttributeLoaded('state')
again.
This commit is contained in:
Piotr Sarnacki 2012-12-10 14:26:44 +01:00
parent a662d03ee7
commit 5b0b7d7002
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
assets/scripts/app/models/build.coffee
View File

@ -60,7 +60,7 @@ require 'travis/model'
Travis.ajax.post '/requests', build_id: @get('id') Travis.ajax.post '/requests', build_id: @get('id')
isAttributeLoaded: (key) -> isAttributeLoaded: (key) ->
if ['_duration', 'finishedAt', 'state'].contains(key) && !@get('isFinished') if ['_duration', 'finishedAt'].contains(key) && !@get('isFinished')
return true return true
else else
@_super(key) @_super(key)

2
assets/scripts/app/models/job.coffee
View File

@ -82,7 +82,7 @@ require 'travis/model'
).observes('state') ).observes('state')
isAttributeLoaded: (key) -> isAttributeLoaded: (key) ->
if ['finishedAt', 'state'].contains(key) && !@get('isFinished') if ['finishedAt'].contains(key) && !@get('isFinished')
return true return true
else if key == 'startedAt' && @get('state') == 'created' else if key == 'startedAt' && @get('state') == 'created'
return true return true