From d32fe183ad900373dc64ec64a50f7a434fbae1a3 Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Mon, 18 May 2015 15:00:52 +0200 Subject: [PATCH 1/5] cleanup some top styles --- app/styles/app/layouts/top.sass | 26 ++++++++++---------------- app/templates/top.hbs | 2 +- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/app/styles/app/layouts/top.sass b/app/styles/app/layouts/top.sass index e1a0078b..fe71dfaf 100644 --- a/app/styles/app/layouts/top.sass +++ b/app/styles/app/layouts/top.sass @@ -80,16 +80,13 @@ $top-height: 55px color: $grey1 .navigation + padding: 0 $column-gutter/2 + margin: 0 height: 0 + list-style: none overflow: hidden &.is-open height: auto - a - padding: .5em 1em - - .navigation, - .navigation-nested - @include resetul .navigation-handle position: relative @@ -98,11 +95,13 @@ $top-height: 55px .navigation-sub position: relative + .navigation-nested + @include resetul + a, - .navigation-handle span:not(.sync-spinner) + .navigation-handle display: block color: #898989 - border-bottom: solid 1px #eff0ec font-size: $font-size-m cursor: pointer height: $top-height @@ -111,7 +110,8 @@ $top-height: 55px &:hover text-decoration: underline - .navigation--profile + .profile + float: right img border-radius: 50%; width: 2.7rem; @@ -124,6 +124,7 @@ $top-height: 55px height: $top-height .navigation + padding: 0 height: $top-height overflow: visible > li @@ -138,13 +139,6 @@ $top-height: 55px .navigation-handle span:not(.sync-spinner) padding: 0 .2em - .navigation--profile - float: right - - .navigation--profile.signed-out, - .navigation--profile.signing-in - line-height: $top-height - 5px - .navigation-nested display: none position: absolute diff --git a/app/templates/top.hbs b/app/templates/top.hbs index 3aaf1c40..f34c80c8 100644 --- a/app/templates/top.hbs +++ b/app/templates/top.hbs @@ -41,7 +41,7 @@ {{/if}} -
  • +

  • {{#if auth.signedOut}} From 0b658dab7325fc531b30b76a1586fa34bcbc4c7a Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Mon, 18 May 2015 15:28:08 +0200 Subject: [PATCH 2/5] fix typo on getting_started --- app/templates/getting-started.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/getting-started.hbs b/app/templates/getting-started.hbs index 3bfe819d..b69a21f9 100644 --- a/app/templates/getting-started.hbs +++ b/app/templates/getting-started.hbs @@ -10,7 +10,7 @@

    Activate GitHub Repositories

    Once you're signed in, and we've initially synchronized your repositories from GitHub, go to your {{#link-to "profile"}}profile{{/link-to}} page for open source or for your private projects.

    -

    You'll see all the organizations you're a member of and all the repositories you have access to. The ones you administrative access to are the ones you can enable the service hook for.

    +

    You'll see all the organizations you're a member of and all the repositories you have access to. The ones you have administrative access to are the ones you can enable the service hook for.

    Flip the switch to on for all repositories you'd like to enable.

    • From 621b5750f08247e8ce1c29c7479c7df924cf945e Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Mon, 18 May 2015 15:59:54 +0200 Subject: [PATCH 3/5] fix committer has author avatar issue --- app/controllers/builds-item.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/builds-item.coffee b/app/controllers/builds-item.coffee index 50cc588a..5373764b 100644 --- a/app/controllers/builds-item.coffee +++ b/app/controllers/builds-item.coffee @@ -13,7 +13,7 @@ Controller = Ember.ObjectController.extend(GithubUrlProperties, ).property('build.state') urlAuthorGravatarImage: (-> - gravatarImage(@get('build.commit.authorEmail'), 40) + gravatarImage(@get('build.commit.committerEmail'), 40) ).property('build.commit.authorEmail') ) From 4559a8441f65cbcc3eb8ddf4b90613852b8b4216 Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Tue, 19 May 2015 11:28:42 +0200 Subject: [PATCH 4/5] remove outline from logo --- app/styles/app/layouts/top.sass | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/styles/app/layouts/top.sass b/app/styles/app/layouts/top.sass index fe71dfaf..e380bbc9 100644 --- a/app/styles/app/layouts/top.sass +++ b/app/styles/app/layouts/top.sass @@ -44,12 +44,13 @@ $top-height: 55px width: 100px height: $top-height z-index: 999 - border: none !important - text-indent : -9999px + outline: none + text-indent: -9999px transition: background-color 200ms ease - background : inline-image('svg/travis-ci-logo.svg') no-repeat 0 50% + background: inline-image('svg/travis-ci-logo.svg') no-repeat 0 50% + &:hover - background : $cream-light inline-image('svg/travis-ci-logo-hover.svg') no-repeat 50% + background: $cream-light inline-image('svg/travis-ci-logo-hover.svg') no-repeat 50% .centered & margin-left: 0 From 3d21fd88a7c90b0b5407789116a5340a39c89061 Mon Sep 17 00:00:00 2001 From: Lisa Passing Date: Tue, 19 May 2015 11:47:06 +0200 Subject: [PATCH 5/5] change irc link to chat.travis --- app/templates/top.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/top.hbs b/app/templates/top.hbs index f34c80c8..748fcbd1 100644 --- a/app/templates/top.hbs +++ b/app/templates/top.hbs @@ -16,7 +16,7 @@