Only hide #log element, so it's always in the DOM

When a job is not started, we will show a message that the log can't be
shown. If a pusher message with a state change comes after the first log
pusher message, travis-web-log will error out, because in such a
situation a DOM element wouldn't be available. To make it always work,
this commit changes the behaviour to just hide #log element with CSS
instead of using {{#if}}.
This commit is contained in:
Piotr Sarnacki 2016-01-29 16:32:49 +01:00
parent 7764479c14
commit 6deae83a1b
2 changed files with 9 additions and 3 deletions
app
styles/app/main
templates/components

View File

@ -248,3 +248,6 @@
@media #{$medium-up}
height: 70px
line-height: 70px
.log-container.hidden
display: none

View File

@ -25,8 +25,10 @@
{{/if}}
{{#if job.notStarted}}
<div class="log-notice">Hang tight, the log cannot be shown until the build has started.</div>
{{else}}
<div class="log-notice {{if logStarted 'hidden'}}">Hang tight, the log cannot be shown until the build has started.</div>
{{/if}}
<div class="log-container {{if job.notStarted 'hidden'}}">
<a href="#" class="toggle-log-button {{if logIsVisible 'hidden'}}" title="Display the log" {{action "toggleLog"}}>
{{eye-icon}}
<span class="label-align">View log</span></a>
@ -62,11 +64,12 @@
{{/if}}
</div>
</div>
{{#if limited}}
<p class="warning">
This log is too long to be displayed. Please reduce the verbosity of your
build or download the <a href={{plainTextLogUrl}}>raw log</a>.
</p>
{{/if}}
{{/if}}
</div>
</section>