suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Observe repos.firstObject on reposController

Browse Source 
Since we change repos property on reposController, we can't set observer
on repos, because as soon as it's changed, we loose the observer.
Instead, we should observe only on reposController, which is not going
to change.
This commit is contained in:
Piotr Sarnacki 2015-11-09 13:24:57 +01:00
parent 8de314e943
commit 6ee956367c
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/repos.coffee
View File

@ -3,7 +3,6 @@
`import Repo from 'travis/models/repo'`
Controller = Ember.Controller.extend
contentBinding: 'repos'
actions:
activate: (name) ->
@activate(name)

8
app/routes/main-tab.coffee
View File

@ -12,12 +12,12 @@ Route = TravisRoute.extend
@controllerFor('repos').activate(@get('reposTabName'))
@currentRepoDidChange()
if repos = @controllerFor('repos').get('repos')
repos.addObserver('firstObject', this, 'currentRepoDidChange')
if repos = @controllerFor('repos')
repos.addObserver('repos.firstObject', this, 'currentRepoDidChange')
deactivate: ->
if repos = @controllerFor('repos').get('repos')
repos.removeObserver('firstObject', this, 'currentRepoDidChange')
if repos = @controllerFor('repos')
repos.removeObserver('repos.firstObject', this, 'currentRepoDidChange')
@_super.apply(this, arguments)