Make env var form play better with oneliners

This commit is contained in:
Piotr Sarnacki 2014-08-20 14:41:31 +02:00
parent 3c847bbb38
commit 71b4c6b865
4 changed files with 51 additions and 15 deletions

View File

@ -86,6 +86,8 @@ Ember.Handlebars.registerHelper('travis-field', (name, options) ->
controller: this controller: this
template: template template: template
errors: errors errors: errors
name: name
classNameBindings: ['name']
) )
Ember.Handlebars.helpers.view.call(this, view, options) Ember.Handlebars.helpers.view.call(this, view, options)

View File

@ -2,10 +2,10 @@
<ul class="env-vars"> <ul class="env-vars">
{{#each controller itemController="envVar"}} {{#each controller itemController="envVar"}}
{{#if isEditing}} <li class="env-var">
{{partial 'env_vars/form'}} {{#if isEditing}}
{{else}} {{partial 'env_vars/form'}}
<li class="env-var"> {{else}}
<span class="name">{{name}}</span> <span class="name">{{name}}</span>
<span class="equals">=</span> <span class="equals">=</span>
<span class="value value-display">{{value}}</span> <span class="value value-display">{{value}}</span>
@ -13,7 +13,7 @@
<a href="#" {{action "delete"}} {{bind-attr class=":delete-var isDeleting:deleting"}}> <a href="#" {{action "delete"}} {{bind-attr class=":delete-var isDeleting:deleting"}}>
Delete Delete
</a> </a>
</li> {{/if}}
{{/if}} </li>
{{/each}} {{/each}}
</ul> </ul>

View File

@ -1,17 +1,21 @@
<form class="env-var" {{action "save" on="submit"}}> <form class="env-var" {{action "save" on="submit"}}>
{{#travis-field "name"}} {{#travis-field "name"}}
{{#label for="name"}}Name:{{/label}} {{#label for="name" class="name"}}Name:{{/label}}
{{input value=name class="env-name"}} {{travis-errors "name"}} {{input value=name class="env-name" placeholder="Name"}} {{travis-errors "name"}}
{{/travis-field}} {{/travis-field}}
<span class="equals">=</span>
{{#if showValueField}} {{#if showValueField}}
<div class="field"> <div class="field value">
{{#label for="value"}}Value:{{/label}} {{#label for="value" class="value"}}Value:{{/label}}
{{input value=value class="env-value"}} {{input value=value class="env-value" placeholder="Value"}}
</div> </div>
{{else}}
<span class="value value-display">{{value}}</span>
{{/if}} {{/if}}
<div style="clear: both"></div>
<div class="field"> <div class="field">
{{travis-switch active=public class="value"}} {{travis-switch active=public class="value"}}
{{#label for="secure" class="value"}}Display value in build logs{{/label}} {{#label for="secure" class="public"}}Display value in build logs{{/label}}
</div> </div>
<div class="actions"> <div class="actions">

View File

@ -197,6 +197,35 @@
border-bottom: 1px dotted #bbb border-bottom: 1px dotted #bbb
max-width: 800px max-width: 800px
form
padding-left: 15px
width: 100%
label.name, label.value
display: none
label.public
width: 80%
.field.name, .field.value
float: left
padding-bottom: 0
height: 33px
span.equals
float: left
display: block
.field.name
width: 30%
input
width: 95%
.field.value
width: 45%
input
width: 95%
.actions
margin-bottom: 10px
.var .var
font-size: 13px font-size: 13px
display: inline-block display: inline-block
@ -208,7 +237,7 @@
text-align: left text-align: left
margin-right: 5px margin-right: 5px
.name, .value, .equals span.name, span.value, .equals
display: block display: block
float: left float: left
position: relative position: relative
@ -217,10 +246,11 @@
.equals .equals
margin: 0 10px margin: 0 10px
.name span.name
width: 30% width: 30%
text-align: right text-align: right
.value span.value
width: 45% width: 45%
text-align: left text-align: left
margin-right: 15px