From c20134d8ae6095b2aca92899a616cc76b90fc0a5 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Mon, 23 Mar 2015 13:58:47 +0100 Subject: [PATCH 1/2] Change jobs list items into divs again --- app/components/jobs-item.coffee | 2 +- app/templates/components/jobs-list.hbs | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/components/jobs-item.coffee b/app/components/jobs-item.coffee index ca085418..d8069bda 100644 --- a/app/components/jobs-item.coffee +++ b/app/components/jobs-item.coffee @@ -3,7 +3,7 @@ `import { languageConfigKeys } from 'travis/utils/keys-map';` JobsItemComponent = Ember.Component.extend - tagName: 'li' + tagName: 'div' classNameBindings: ['job.state'] classNames: ['tile', 'tile--jobs', 'row'] diff --git a/app/templates/components/jobs-list.hbs b/app/templates/components/jobs-list.hbs index ff8a0243..a45627af 100644 --- a/app/templates/components/jobs-list.hbs +++ b/app/templates/components/jobs-list.hbs @@ -12,10 +12,8 @@ {{/if}} - {{/if}} From 95b8fe485bf6e1947f1e0af9b66a71e747d830a1 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Mon, 23 Mar 2015 14:02:16 +0100 Subject: [PATCH 2/2] Fix tests --- tests/unit/components/jobs-list-test.coffee | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/components/jobs-list-test.coffee b/tests/unit/components/jobs-list-test.coffee index 76a40abe..dece86b5 100644 --- a/tests/unit/components/jobs-list-test.coffee +++ b/tests/unit/components/jobs-list-test.coffee @@ -12,9 +12,9 @@ test 'it renders a list of jobs', -> @append() equal component.$('.build-title').text().trim(), 'Build Jobs' - equal component.$('li').length, 2, 'there should be 2 job items' - ok component.$('li:nth(0)').hasClass('passed'), 'passed class should be applied to a job' - ok component.$('li:nth(1)').hasClass('failed'), 'failed class should be applied to a job' + equal component.$('.tile--jobs').length, 2, 'there should be 2 job items' + ok component.$('.tile--jobs:nth(0)').hasClass('passed'), 'passed class should be applied to a job' + ok component.$('.tile--jobs:nth(1)').hasClass('failed'), 'failed class should be applied to a job' test 'it renders "Allowed Failures" version without a `required` property', -> jobs = [Ember.Object.create(id: 1)]