From 89a3c20217c4fab8fa91e646827e1a433419f293 Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Wed, 5 Nov 2014 12:48:26 -0500 Subject: [PATCH] Keep elements fully within a single element. {{if}} is implemented as an Ember.View (without an element), and children must be valid DOM. --- assets/scripts/app/templates/jobs/list.hbs | 17 ++++++++--------- assets/scripts/app/views/job.coffee | 7 +++++++ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/assets/scripts/app/templates/jobs/list.hbs b/assets/scripts/app/templates/jobs/list.hbs index 93f2685f..d576baee 100644 --- a/assets/scripts/app/templates/jobs/list.hbs +++ b/assets/scripts/app/templates/jobs/list.hbs @@ -1,15 +1,14 @@ {{#if view.jobs.length}} + {{#if view.required}} -
- + {{else}} -
- Build Matrix - + Build Matrix +
- + {{/if}} diff --git a/assets/scripts/app/views/job.coffee b/assets/scripts/app/views/job.coffee index 44cb5862..40d89b14 100644 --- a/assets/scripts/app/views/job.coffee +++ b/assets/scripts/app/views/job.coffee @@ -3,6 +3,13 @@ Travis.reopen templateName: 'jobs/list' buildBinding: 'controller.build' + jobTableId: Ember.computed(-> + if @get('required') + 'jobs' + else + 'allowed_failure_jobs' + ) + JobsItemView: Travis.View.extend tagName: 'tr' classNameBindings: ['color']
- Allowed Failures - - + Allowed Failures + +