move AltVersions to its own file, try setting domain and secure on the cookie

lib/travis/web/app.rb

@@ -6,6 +6,7 @@ require 'delegate'
 require 'time'
 
 class Travis::Web::App
+  autoload :AltVersions,    'travis/web/app/alt_versions'
   autoload :MobileRedirect, 'travis/web/app/mobile_redirect'
 
   S3_URL = 'https://s3.amazonaws.com/travis-web-production/assets'
@@ -24,42 +25,6 @@ class Travis::Web::App
     end
   end
 
-  class AltVersions
-    attr_reader :app
-
-    def initialize(app)
-      @app = app
-    end
-
-    def call(env)
-      alt = alt_from(env)
-      env['travis.alt'] = alt if alt
-      status, headers, body = app.call(env)
-      set_cookies(headers, env['travis.alt']) if env.key?('travis.alt')
-      [status, headers, body]
-    end
-
-    def set_cookies(headers, alt)
-      headers['Set-Cookie'] = "alt=#{alt}; Max-Age=#{alt == 'default' ? 0 : 86400}"
-    end
-
-    def alt_from(env)
-      alt_from_params(env) || alt_from_cookie(env)
-    end
-
-    def alt_from_params(env)
-      alt_from_string env['QUERY_STRING']
-    end
-
-    def alt_from_cookie(env)
-      alt_from_string env['HTTP_COOKIE']
-    end
-
-    def alt_from_string(string)
-      $1 if string =~ /alt=([^&]*)/
-    end
-  end
-
   class << self
     def new(options = {})
       return super unless options[:environment] == 'development'
@@ -68,7 +33,7 @@ class Travis::Web::App
 
     def build(options = {})
       builder = Rack::Builder.new
-      if options.fetch(:environment) == 'production'
+      if options[:environment] == 'production'
         builder.use Rack::SSL
         builder.use Rack::Cache
       end
@@ -84,11 +49,10 @@ class Travis::Web::App
     end
   end
 
-  attr_reader :routers, :environment, :version, :last_modified, :age, :options, :root
+  attr_reader :routers, :version, :last_modified, :age, :options, :root
 
   def initialize(options = {})
     @options       = options
-    @environment   = options.fetch(:environment)
     @root          = options.fetch(:root)
     @version       = File.read File.expand_path('version', root)
     @last_modified = Time.now
@@ -118,7 +82,6 @@ class Travis::Web::App
     def response_for(file, options = {})
       content = File.read(file)
       set_config(content, options) if config_needed?(file)
-
       headers = {
         'Content-Length'   => content.bytesize.to_s,
         'Content-Location' => path_for(file),
@@ -130,13 +93,11 @@ class Travis::Web::App
         'Expires'          => (last_modified + age).httpdate,
         'Vary'             => vary_for(file)
       }
-
       [ 200, headers, [content] ]
     end
 
     def each_file
-      pattern = File.join(root, '**/*')
-      Dir.glob(pattern) { |f| yield f if File.file? f }
+      Dir.glob(File.join(root, '**/*')) { |file| yield file if File.file?(file) }
     end
 
     def prefix?(file)

lib/travis/web/app/alt_versions.rb

@@ -0,0 +1,33 @@
+class Travis::Web::App::AltVersions
+  attr_reader :app
+
+  def initialize(app)
+    @app = app
+  end
+
+  def call(env)
+    alt = alt_from_params(env) || alt_from_cookie(env)
+    env['travis.alt'] = alt if alt
+    status, headers, body = app.call(env)
+    headers['Set-Cookie'] = cookie(alt) if env.key?('travis.alt')
+    [status, headers, body]
+  end
+
+  private
+
+    def cookie(alt)
+      "alt=#{alt}; Domain=travis-ci.org; Secure; Max-Age=#{alt == 'default' ? 0 : 86400}"
+    end
+
+    def alt_from_params(env)
+      alt_from_string env['QUERY_STRING']
+    end
+
+    def alt_from_cookie(env)
+      alt_from_string env['HTTP_COOKIE']
+    end
+
+    def alt_from_string(string)
+      $1 if string =~ /alt=([^&]*)/
+    end
+end

spec/app_spec.rb

@@ -42,12 +42,12 @@ describe Travis::Web::App do
       example { last_response.should be_ok }
       example { last_response.body.should include('/assets/foo/styles/app.css') }
       example { last_response.body.should include('/assets/foo/scripts/app.js') }
-      example { headers['Set-Cookie'].should == 'alt=foo; Max-Age=86400' }
+      example { headers['Set-Cookie'].should == 'alt=foo; Domain=travis-ci.org; Secure; Max-Age=86400' }
     end
 
     context 'passing default as an alt param' do
       before  { get('/?alt=default') }
-      example { headers['Set-Cookie'].should == 'alt=default; Max-Age=0' }
+      example { headers['Set-Cookie'].should == 'alt=default; Domain=travis-ci.org; Secure; Max-Age=0' }
     end
   end
 end