suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't filter env vars in controller

Browse Source 
Depending on isNew can result in rerendering templates in some cases, which will
also create a new object controller, which in turn will reset isEditing value.
This commit is contained in:
Piotr Sarnacki 2015-02-06 13:20:56 +01:00
parent ab33383d15
commit 95619b42fb
2 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/env-vars.coffee
View File

@ -1,6 +1,6 @@
`import Ember from 'ember'` `import Ember from 'ember'`
Controller = Ember.ArrayController.extend Controller = Ember.ArrayController.extend
vars: Ember.computed.filterBy('model', 'isNew', false) vars: Ember.computed.alias('model')
`export default Controller` `export default Controller`

26
app/templates/env-vars.hbs
View File

@ -2,17 +2,19 @@
<ul class="env-vars"> <ul class="env-vars">
{{#each vars itemController="envVar"}} {{#each vars itemController="envVar"}}
<li class="env-var"> {{#unless isNew}}
{{#if isEditing}} <li class="env-var">
{{partial 'env_vars/form'}} {{#if isEditing}}
{{else}} {{partial 'env_vars/form'}}
<a href="#" class="edit-var" {{action "edit"}}>Edit</a> {{else}}
<a href="#" {{action "delete"}} {{bind-attr class=":delete-var isDeleting:deleting"}}> <a href="#" class="edit-var" {{action "edit"}}>Edit</a>
Delete <a href="#" {{action "delete"}} {{bind-attr class=":delete-var isDeleting:deleting"}}>
</a> Delete
<span class="name">{{name}}</span> </a>
<span {{bind-attr class=":value :value-display public::secure"}}>{{value}}</span> <span class="name">{{name}}</span>
{{/if}} <span {{bind-attr class=":value :value-display public::secure"}}>{{value}}</span>
</li> {{/if}}
</li>
{{/unless}}
{{/each}} {{/each}}
</ul> </ul>