suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show author name and author avatar on builds list

Browse Source
This commit is contained in:
Jonas Weber 2016-01-01 17:11:17 +01:00 committed by Piotr Sarnacki
parent 9e94643dc4
commit ab54733723
3 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/components/builds-item.hbs
View File

@ -21,7 +21,7 @@
</div>
<div class="row-item row-committer">
<img class="avatar" src={{build.commit.authorAvatarUrlOrGravatar}} alt="{{build.commit.authorName}} avatar">
<span class="label-align">{{build.commit.committerName}}</span>
<span class="label-align">{{build.commit.authorName}}</span>
</div>
</div>

1
tests/unit/components/builds-item-test.coffee
View File

@ -32,5 +32,4 @@ test 'it renders', (assert) ->
ok component.$().hasClass('passed'), 'component has right status class'
equal component.$('.row-branch a').text().trim(), 'foobarbranch', 'component renders branch if event is push'
equal component.$('.avatar').attr('src'), 'https://www.gravatar.com/avatar/5c1e6d6e64e12aca17657581a48005d1?s=40&d=https%3A%2F%2Ftravis-ci.org%2Fimages%2Fui%2Fdefault-avatar.png', 'component renders right gravatar image'
equal component.$('a[title="See the commit on GitHub"]').attr('href'), 'https://github.com/foo/bar/commit/a5e8093098f9c0fb46856b753fb8943c7fbf26f3', 'component generates right commit link'

25
tests/unit/models/commit-test.coffee Normal file
View File

@ -0,0 +1,25 @@
`import { moduleForModel, test } from 'ember-qunit'`
moduleForModel 'commit', 'Unit | Model | commit', needs: ['model:build']
test 'calculation of avatar urls via Gravatar', ->
model = @subject()
Ember.run ->
model.setProperties
authorEmail: 'author@example.com'
committerEmail: 'author@example.com'
authorAvatarUrl: null
committerAvatarUrl: null
equal model.get('authorAvatarUrlOrGravatar'), 'https://www.gravatar.com/avatar/5c1e6d6e64e12aca17657581a48005d1?s=40&d=https%3A%2F%2Ftravis-ci.org%2Fimages%2Fui%2Fdefault-avatar.png', 'correctly sets gravatar image'
equal model.get('committerAvatarUrlOrGravatar'), 'https://www.gravatar.com/avatar/5c1e6d6e64e12aca17657581a48005d1?s=40&d=https%3A%2F%2Ftravis-ci.org%2Fimages%2Fui%2Fdefault-avatar.png', 'correctly sets gravatar image'
test 'calculation of avatar urls via overriding parameter', ->
model = @subject()
Ember.run ->
model.setProperties
authorEmail: 'author@example.com'
committerEmail: 'author@example.com'
authorAvatarUrl: 'http://example.com/test.jpg'
committerAvatarUrl: 'http://example.com/test2.jpg'
equal model.get('authorAvatarUrlOrGravatar'), 'http://example.com/test.jpg', 'correctly sets avatar'
equal model.get('committerAvatarUrlOrGravatar'), 'http://example.com/test2.jpg', 'correctly sets avatar'