From ae704df6bfaf1691e6a1e264c5d2c135003a7f30 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Tue, 29 Dec 2015 12:49:47 +0100 Subject: [PATCH] Use el.innerHTML = ''; instead of $(el).empty() It turns out that jQuery's empty method can be really slow in Firefox, which can freeze the browser when cleaning the log. --- app/components/log-content.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/components/log-content.js b/app/components/log-content.js index 14110bc4..367a7e1c 100644 --- a/app/components/log-content.js +++ b/app/components/log-content.js @@ -90,8 +90,8 @@ export default Ember.Component.extend({ if ((ref = this.lineSelector) != null) { ref.willDestroy(); } - if (logElement = this.$('#log')) { - return logElement.empty(); + if (logElement = this.$('#log')[0]) { + logElement.innerHTML = ''; } } }, @@ -99,8 +99,8 @@ export default Ember.Component.extend({ createEngine(log) { var logElement; if (log || (log = this.get('log'))) { - if (logElement = this.$('#log')) { - logElement.empty(); + if (logElement = this.$('#log')[0]) { + logElement.innerHTML = ''; } log.onClear(() => { this.teardownLog();