suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Load commit from build:started event payload

Browse Source 
Commit fields come in with build:started payload. We should split it
into 2 separate keys in the payload, like:

    {
      build:  { .... },
      commit: { .... }
    }

but I can't change pusher v1 API at the moment, due to backwards
compatibility with the old client. We will be able to remove this manual
extraction as soon as we switch to pusher v2 API.
This commit is contained in:
Piotr Sarnacki 2012-11-06 14:31:27 +01:00
parent 380f89435b
commit b164e5f1a8
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
assets/scripts/app/store.coffee
View File

@ -67,11 +67,24 @@ Travis.Store = DS.Store.extend
mappings = @adapter.get('mappings')
type = mappings[name]
# TODO: we should definitely handle such things in some kind of adapters
# when we get 'commit' value, ember thinks that this is actually a commit object
# that it should sideload, let's just delete it for now
if event == 'build:started' && data.build.commit
# TODO: commit should be a sideload record on build, not mixed with it
build = data.build
commit = {
id: build.commit_id
author_email: build.author_email
author_name: build.author_name
branch: build.branch
committed_at: build.committed_at
committer_email: build.committer_email
committer_name: build.committer_name
compare_url: build.compare_url
message: build.message
sha: build.commit
}
delete(data.build.commit)
@loadIncomplete(Travis.Commit, commit)
if event == 'job:log'
if job = @find(Travis.Job, data['job']['id'])