From bdb427492f73a37268c4812e074da3edd0416bbb Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Fri, 30 Jan 2015 11:53:28 +0100 Subject: [PATCH] Remove duplicate properties --- assets/scripts/app/models/commit.coffee | 2 -- assets/scripts/app/models/job.coffee | 4 ---- 2 files changed, 6 deletions(-) diff --git a/assets/scripts/app/models/commit.coffee b/assets/scripts/app/models/commit.coffee index 2f456486..664a1222 100644 --- a/assets/scripts/app/models/commit.coffee +++ b/assets/scripts/app/models/commit.coffee @@ -11,8 +11,6 @@ Commit = Model.extend authorEmail: DS.attr() committerName: DS.attr() committerEmail: DS.attr() - subject: DS.attr() - body: DS.attr() commitedAt: DS.attr() build: DS.belongsTo('build') diff --git a/assets/scripts/app/models/job.coffee b/assets/scripts/app/models/job.coffee index de553035..14e129da 100644 --- a/assets/scripts/app/models/job.coffee +++ b/assets/scripts/app/models/job.coffee @@ -124,10 +124,6 @@ Job = Model.extend DurationCalculations, @unsubscribe() if @get('state') == 'finished' && Travis.pusher ).observes('state') - isFinished: (-> - @get('state') in ['passed', 'failed', 'errored', 'canceled'] - ).property('state') - # TODO: such formattings should be done in controller, but in order # to use it there easily, I would have to refactor job and build # controllers