From bf7c4e1464488af534cb49eef53d7402d2ff9fda Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Wed, 18 Feb 2015 16:32:43 +0100 Subject: [PATCH] Fix viewing repo after viewing all repos on safari When transitioning from recent route to a specific repo deactivate is not called for some reason on Safari. It seems like a bug in Ember.js, but I need to investigate more. A solution is to also try to remove observer in reset controller --- app/routes/main-tab.coffee | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/routes/main-tab.coffee b/app/routes/main-tab.coffee index d35a328a..7c454bd5 100644 --- a/app/routes/main-tab.coffee +++ b/app/routes/main-tab.coffee @@ -17,6 +17,9 @@ Route = TravisRoute.extend deactivate: -> @controllerFor('repos').removeObserver('firstObject', this, 'currentRepoDidChange') + resetController: -> + @controllerFor('repos').removeObserver('firstObject', this, 'currentRepoDidChange') + currentRepoDidChange: -> if repo = @controllerFor('repos').get('firstObject') @controllerFor('repo').set('repo', repo)