Remove click handler overriding default link behavior
An [issue](https://github.com/travis-ci/travis-ci/issues/5181) was reported in which the repository sidebar links were not functioning properly. I've tracked it down to the fact that a click handler was registered and automatically performing a redirect to the repo route. This breaks CMD+Click behavior (as the click handler was still called and navigating when the user did not expect it, as well as navigated to a link that the user did not intend to visit. This commit simply removes that click handler. I checked the previous coffee version of the file to gain more context on why it was initially added, but unfortunately, it was simply added when the original component was created, so I'm not sure what its use was.
This commit is contained in:
parent
08bc13aedd
commit
c118153f2f
|
@ -23,10 +23,5 @@ export default Ember.Component.extend(Polling, {
|
|||
scrollTop: 0
|
||||
}, 200);
|
||||
}
|
||||
},
|
||||
|
||||
click() {
|
||||
this.scrollTop();
|
||||
return this.get('routing').transitionTo('repo', this.get('repo.slug').split('/'));
|
||||
}
|
||||
});
|
||||
|
|
Loading…
Reference in New Issue
Block a user