From 9bce26ea3ea913462f2e24775cf5f27b7e1c6a6c Mon Sep 17 00:00:00 2001 From: Mathias Meyer Date: Fri, 10 May 2013 16:49:15 +0200 Subject: [PATCH 1/3] Change repository header to link to Travis repo. Linking this to GitHub is cause for confusion, even for myself. The tiny octocat now points to GitHub instead. --- assets/images/icons/github.png | Bin 0 -> 8105 bytes assets/scripts/app/templates/repos/show.hbs | 7 ++++--- assets/styles/main/repository.sass | 13 +++++++++++++ 3 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 assets/images/icons/github.png diff --git a/assets/images/icons/github.png b/assets/images/icons/github.png new file mode 100644 index 0000000000000000000000000000000000000000..ab99f4720770c632280e102878262942aa35cd28 GIT binary patch literal 8105 zcmb_>WmFv9wrvw!gC;<52~Okg?$9{F-6dFKjRXi5BoHjPOM<(*ySoKPLmCC`qHE5TXD80CZUy3Dw_E{67N;;rD$VEO`5SPHZhM zt|BWgPNw4QXkl$<4ghE)m*`k(1;wmK{okg$oZ-5dpCRVz)4e1b2PLz^85eW9;mwnr-^}`ZH7P8mNFiCRGm) z76n8R87r!VQSIolo|(wk!Z4WafIR@B5v8YO(Ba~|w*Sk8HVOQ=`=(lvz5WZ$v7ck+ z&2`w>D?p`aieL+6vzUqxDj;`&A(aRj;I5ltq+oW-H7d%AL%@mI6TdWn3S6#^6nyD~ z@Dm~OL%y-Y0|LHFP&~kh=!tCmOc?kUk`USeoY1mXVX~~ag>Y>>@8X(a*3U$EW68;l zmv~TnveRECH*bIn6rRr|aT3sncQ2f8t7-VkMMWe$Sm+#f`(Adbsd!MX=0-aL4T>l~ z9gR%zqaM_017ouU!xvP1CfE9=f7Lb93#g8r)HQRGO-{q~D9~DV3lDambEik3I8RHm zzNKG7LSbLq$?^TPASPJy6Ey5^B3gz7nZ8*v?HD|N#u#nmeX}Zr@R?Rh3+qS>qw1mS zCOWkCg)%z&X0GnO>orxfeP0T~wq;B|?P3KYGZdL?l?42jz73niy2^g{TKg%hL$hu7 z)!1!pWG(L!lrtkV?apCohjjnc=+hu51*=h}vWp8bjk0t5osn6%$uyV5Y=#|Fx)g_` zxhj96H58V2&|&HIC)(>PWVhw(jaq@O6tnVU-Dw&bWR_P{A_zk5I6fg)K;62g#9 zMsbis`d929mr8|mVpIldwQ2>4V1_}!d;h{T!z{nvhu1*Kr;*!|0I5_dL3T!*LDNPX1gy2?M3I#z#g9ISg;%8>OxA>DmgfxWxr9Wt5_lrKd|2uaB z(AHktrE#sJwg|G-M8PNGGXM-(xR(S8Ei8H_ELs3TIRZvI-jVoRxiFF_Qxr@{J5~$| znB* zHbkAAsUNe_|A54lTq$FyYg{p$?N^JA_L^L{+d=LH-;d@A{s4dGY zwJrq~Zbr1B_TqA8I}HAIZ)4$G0MYA$cA5=}dZN}>-0e5(eP`?*D9=bhazK`tHm0ux z3P|!2%eEW+T(Vz=A~pb*Vq1oI@>6L~K|gM#|4$Pqd?_?iDU`@u{1VIU*cP;h*Ev8iGOv$n7u8W)~!Xi4X4uY1ne1^*EnMu=%g*t+`o z%t<(EH*vT5hTO-idW>aE2g16bzRiVmY!Ag|&h((@?t))q>t*Xp=Uunp+YC7RS3uEp zBMB$UAnaJ=;Gm%(u1*%?gmNWOX>y4yC1b@6MJ(yBiXhnuF;UD2z;*uwC_QjlP-mw1ibhzOHXiSn@$u_Pq+9@`D^ z3iaSrf&!FODDFxrg{_Qj8>-(e`%9TniqM)+jnMIX7e@~VI!6~rhBcj4u$7zj%|!3i zo5|H&;!OR_oJ^ejsRGIg>PfsQ&Z)==rU~}Rp$Xloka5ci!+bvp;XZ#$ObZsXGYc8x zLZdyCBnt_Ac>F7Z7W`;7O*VJ-R?|+_FqULCcs6r3ee(m$4`vodnr7}MQRd7RtwRDm zpURP{k}Bb<%&L}+2+Va%w=HJOuZ$HfOH7F^^o=*ori?F)hm3w$diU1$j`lh9lXRyK zt@aCb1Z-gLmT!k{@bpcLRJ0Ft7j^9SBzJfQx}>7+VDDCL^7U(U%=FcCk964&6OTeZ zH$`{{gak{6(8SPW6hvC4Cw|q6;P&Uvs7t$nC1uZGHe@lxT7$Go`ZD|CJkvg-K0ZAj zHc7bip2)3gwAqUJtBPo}Ympgdsu_V|w8mA>VvI`G>oJ34ieuWwt+Pn7@QksHEjKnh zBRgFv>?ran&M9gr$|Ss%GE4Rx#lIKO> zWp6NRc+=nr{RK6E_CP67B;YB7yHFHS4DqOOA-H37LRu#3mFj$@(?!)qKeH7yOV!e~ zu+-00=s*N&=BhQI5miXxXN@T}{-3kOwZ)}BNs4^MpCUeglZxpzk8D_>Xo9$Foutn$ z=gCesXY%It6l`a?8Q99D7^dXvmp*Aqi}dLh$XRM?DR8UYgr8Un>Ihb@+PC0A+@9c` zFkrje=gGP<*J3)xC(eFu*tku;^=4D2O-uZ`mprx(Yn=AZ_gBAk+B$E$*? zdf1uXx!$oHS^E&G8^iR0(O8~+NMJ}yQ%o~UGjg_lahh+;t5d3b$A5%aH?<_vzT()M zpSMZeUGVzL^}{i63CO?4YsTN~itF~p`N%cf%^6($@xw_aK?xg4>$6NBc_XJWMZEASd+Vo(36L-CK+3v;Tt#>_7rV}?P zE1#a9PMscMaBoo1BII@GvFkndV0E7gO}?7B6x`nZ+rQ_1J3$Ibs7zDR(hV$1!4Ugx8p9i z=))ZDVMo_h^%fnl{GR53eeV(hx{A17mr0J_rh1(1luDJ3i)Dn=&@ulcn7Ia8_h!w! zHDyI=Az`w1hGeaE8f&$}Y3y{>b@zERQJ-0#^2Yx32Al#G_A$E5{2^Ue@RYUFH7k7( z{oPx``yDBRu*06(LDQ4O{=l*C_VZ_$_<(%TnvR656>T-jr0lTZTfs>ytH;#M?DO%E zb=iJ2I~M!9Q`J?RwYQ_t(b?gFv6|6$Bd>kuFE&>C&Y}-di!%0v<9*&d`5Z=!Cbmi@ z_J9os4C`9WA(k(``ys!gN2yct2DW3iuj0RC90~u>($MmrO`WrtGvzvaCz)cB!qhhG z*RqJRu!utQRhED46_Qsl1OjvGjyw{f2V+De(MD(WJQ(SYzqiXAZcr6VJo6z)(X$NpH)LNM-orOaWOlL2cp3_pI5>XA5qSn#Pbgzy5CH z2?OL)KxI}UDC%R}KrVq9vz4(OfmOUcWN4@1SlRmxBD}P10p>0avs-EO%IcAhtKmXZ zE2)P{?7U!Jvun$-&-KIo?bpX+Sa(Dyyr`&J$1(Y?c=YGHkR>7&>I+FsidKmzsTxVG zzOA13z3_caBpiad$(gZ*KH5yOH=&-D7od!9{ic1Y7tvbzD+;ImdqYGcUJ#S(t%4&* zUipThf&^#+bPk2JAUT3+3_s(FUPw<>{R6nP<>>tGE9&O98s0^`aB+L*h13XpqM{--grj}4*rVQ^ ziq0iY{#XcGmW>?PpQFj=$QNp*^S0%VRG1s%8U5Khu+XQdZpD10!s*fT{bCPRL6!%L?(r!^j=GH|dNRqqs z`rdEooqdO+L&1{6D%PK_lyD=|{Qzu~xM%y!)$3`&_eMh#TbJ;GDN2@^-T^*cuvymU z?d=k{1y>t88+!*2gw2U}ff*gwAJ@!0LnBBN@pUtCtzr3oOgD>Tc{au-5{8N1rQUreRP60!5iRILUjm7K{fr zwqQ@p(vVg|ulg-PS~+T_0;cGjW}EP@ok>lUjg)fvzwkGwUS7*MLa%b*=~(-&^S={w z%T&qGm=g^&Cta;~Zw-ts$n!EZ$QQKkGVS=$YtugZ-0u=JR@wAqQETKq?dA{djI}kL zH9kuAsBCvd*lUy|di@aA-zi)1&f7YO@XEKSCv!-2Kzw!WuO9TaUYgDm}qyQ#C?O^v!4W!u1a(_<8?T1`6dqQOGbPaq({5mW?Oj;&M1}fj7dNFCr_S#%` zi+SiR9TlAyZ4uq(H$-(5b^Yo28H2(^8;{e3xo&GE8%`_B!`nl`J>H8BdpPe{&MY~E0RWrIgRB*B_WK9vq
}5LL#niZ{NruMqPR4U9=0S-;%hMVHu1SU z7Y}`Ur~4OryxeCVp|oqN79mQ8xNmtLul!6Nw`z{Qq-N@Es-YE-Y#k5i_D2K9nWp*E z+&?>U<#^ux7%rIE0C-<5< zo-JAuk5o`B9ie72EtzjJvF|-jCk{DHJG49Wg7_W6_(ea9w@K@?%#lW4+h0eZ9}x%$ za@?u=Zgp3UnO={j^xYZ0QRr{Z_rzh3<9&NGaIgd|K6Zb6DgJ8ThT}8{*vj(EpF+M& zMI@`k0&MUD%2i((iNm#vqPO=Q0_^kxH8Ux*6~aOi&b7zYMNiB*1_JmMb4_{ezE|`6}lB;A9FtrepGUa|L6^sIeXlKv}?7Ww#b73G-s-3`6{(e<)ICQLHHm$&|`8p z@qmkJ*yIVDO{GF*gtPJ%kRg}ho*|h|{s+qsyCPrJ6m`u86C;tFxPu6Yr_ln*D5=P1%u9!BdC; zz3fxEa0@)-2oil)b6*C3fS87CfPRJYPRK~YAyWNIarD>l7LvAybtAEP!Ttw-Dl z)1khLDQfn{Djy{_%eGNSEH|iJqZ_PQ(*0}s`QqdDE<+zsb|$rrLYLd^sj~zUsXpRX z;=M%8=h+lVl5hih9g4vey%iPKitpuian_%Nbv`+;2Pvlp!QKdYd16tFq8~m!lK?H#El@EOJ~m*O%&?k5B}x-! zwG&?(uGW9xOs5|8`I8g*PCt1rNwTP|p?i{o0{5Fv82r$*dPi}gA6(jI)x49^tL z??e-0q&<|gM88T`h*$^p`UDOJAH4aF99JYAYSVqeq0UjkQB_@9{p2d;N__d@@)+$N zt>w%07aS{##@^Hsicx6N72qAJE^HIigLf2<5``soBE}pVm^qpNh<*yUruZD!^a}10 zZUIghWd&~(>l|+e2M60ShD^pJ4{4Hv4XyIh8LmO&jyIUK#~{yp@J8KB!>|}KmASz5 z!}P14kGYCDTp8d-|W+Z>f`Wm{V;M{hFA$l2ge^I5t5F6i1Z?25y=w%C8`lu zkVO8iB|!${%=43zN$18srLXk9s+St&l+%76JFAX04R2MGbKHd<%B8Yx>ICg9tp)>5 zlRurG3W0u)=e|RvCDTQGSmTK;EO&y#5GRR^@3P#I#klCn&qm?3oSQwV3_ZVr_3pFi zuVpz^V+DP?22UR7Em^4+UNk(mY=-rjQ0h(Z8M!l?7q3C7xt(akAN=Pb69pM0C0w#F zOhyr!J=h}T^$7Rvh@r1a&~?Pj3Xu-{h1wa*VTh2mIyR96O~P}@i2L7vNDk|(HsUI8 zoJTvtS3(2BaR`J&7Rcsr7aV806zJxU z8ONA-bm9+6m=#;hn)>!&_YHO}j=9IK#ED0%rACC=rg?uV2)n^GL~83{)`8&?OhzkjH?u`G9BULuWJPX%1&MtV1TC(8Y##?14#OJeKx!$Dah5UQfvU6R ziPuTdA#a8JxbCs*wC}IF>k3a1*0g-}3@Sf(H5|1yH)FT3y-YprwiiF!920(I^0D{O zw{Ed|I{dsZb=P~J-?cMi*bhuJ)T+&7>MI#qI*&fn5IKzBg8?08ZTAh7l$>?~)|Fw( zlbdR43|ebybOPSLD+BByJs8*LKxbRNympv}ZOpb2Kq$_ON&Q%?1DjJotW3?af_{ z$vo`s99;N31S$Sv@co|ufq@ice^Fd*1u3)@Rmj90oz2NOnOT|HD1=bR$jAho%`Es- zC8Yl8{`*ak!phavi4O<_gTc&Tc4kLsOCT#RFE5aV4ammE^qaxt;_2XO?7`&VLivv% z{~brd+{M({+R4@0(ShtwTw@bQH&;Olia&||b^W7Ga}Vo(XL4})r>x%sfqyJOR%RC9 zzheJ(75IblsaSiM+v!MH+nYPM{LUf7!7cC?{XY!<}WBE^+e^5RhRdW|dJGVb=6yjzR0R9K~H+g^A#2xLO zoXuVS>IvsR`G3d$Ctv%2m*DT<|L->Z-lPB8R{zUldl){kyO{#PEJqb!XqNarBjsYdwKCee0?iP2npp#NlAl7LN3qG$+fh!_yh&b zn<64mnV6U=4Aj-TkMHj8niFf6mUQFO(iBfmPdV7w#3m*tj*`B96;)PN{`qnVJv+5+6_T3E=ctYmX`amiU&&|z~Ly&{BKV?j4JO})ImAHwFUg@uK2OaM+)G&Jlq^^qeZ zid^foC#cXhI;KIWiP-^f$s)()<>h59snkEm%Pjt66B0_7lam{MztOoK zIX|z>#Rvpe5fKyTb#;jo5)tK&jw%ff4N+2kccoyXq6&%;K0ZG7xu95p>kK|jjj^Jm zqmzpkJ3cv~Z@HkSp^+vgCf-l>6Q{v4gsDf^N={A1y&%OVI+ImY)M!kn?V6g3J9W8S zU0YMuW@7|NO2WH=!D`adh&9#K{p$+6TwE3hn(#yb8@PIXmhIwV`p)XhNV%4l7Ij@+ z`TNRWHlH_d&d!Xsjfma7$=(nZqSK1_>o^$|78Py$0_o`~xVgDm2yjhcadB}C@1&=b z5R#JaQq0WFS-v4*f2|TmNJuyj6LocUrB|VVP|}Z}yA;!Lh6nBKm3lw-uFGKujS7jn zyr?M5!NGxN{}Lv1W=4aHQid;}lsi^aQ?q_VXW;P%EX&3!DG5n_Lqmgbcq>{becqla zDFgy3c|S|+4nURi@bgoinwolC`V=95!sO@Y_iQhU@pQQaMP27?E_7YJ8~^i-l$BJH JC>1mM^j|rhL2Cd2 literal 0 HcmV?d00001 diff --git a/assets/scripts/app/templates/repos/show.hbs b/assets/scripts/app/templates/repos/show.hbs index 63ce6e62..599c3ddd 100644 --- a/assets/scripts/app/templates/repos/show.hbs +++ b/assets/scripts/app/templates/repos/show.hbs @@ -7,9 +7,10 @@ {{else}} {{#if repo.isLoaded}} {{#with repo}} -

- {{slug}} -

+
+

{{#linkTo "repo" this}}{{slug}}{{/linkTo}}

+
+

{{description}}

diff --git a/assets/styles/main/repository.sass b/assets/styles/main/repository.sass index d90963f5..c1ead7e7 100644 --- a/assets/styles/main/repository.sass +++ b/assets/styles/main/repository.sass @@ -6,6 +6,19 @@ overflow-x: hidden padding-right: 10px + h3 + display: inline-block + margin-right: 5px + + .github-icon + width: 21px + height: 21px + display: inline-block + + .github-icon + img + margin-top: 2px + .not-found display: block padding: 10px 5px From d04988138d33ed406d3eba5ada67f4f4e290ac5d Mon Sep 17 00:00:00 2001 From: Mathias Meyer Date: Fri, 10 May 2013 17:05:45 +0200 Subject: [PATCH 2/3] Fix specs and expectations for URL changes. --- assets/scripts/spec/build_spec.coffee | 2 +- assets/scripts/spec/builds_spec.coffee | 2 +- assets/scripts/spec/current_spec.coffee | 2 +- assets/scripts/spec/index_spec.coffee | 2 +- assets/scripts/spec/job_spec.coffee | 2 +- assets/scripts/spec/my_repos_spec.coffee | 2 +- assets/scripts/spec/support/expectations.coffee | 1 + 7 files changed, 7 insertions(+), 6 deletions(-) diff --git a/assets/scripts/spec/build_spec.coffee b/assets/scripts/spec/build_spec.coffee index dfd7a5a8..5706ca74 100644 --- a/assets/scripts/spec/build_spec.coffee +++ b/assets/scripts/spec/build_spec.coffee @@ -14,7 +14,7 @@ describe 'on the "build" state', -> ] displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysSummary type: 'build' diff --git a/assets/scripts/spec/builds_spec.coffee b/assets/scripts/spec/builds_spec.coffee index 0229547b..09f6d52f 100644 --- a/assets/scripts/spec/builds_spec.coffee +++ b/assets/scripts/spec/builds_spec.coffee @@ -11,7 +11,7 @@ describe 'on the "builds" state', -> ] displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysTabs current: { href: '/travis-ci/travis-core' } diff --git a/assets/scripts/spec/current_spec.coffee b/assets/scripts/spec/current_spec.coffee index d3ab3167..3bdd1cc9 100644 --- a/assets/scripts/spec/current_spec.coffee +++ b/assets/scripts/spec/current_spec.coffee @@ -11,7 +11,7 @@ describe 'on the "current" state', -> ] displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysSummary type: 'build' diff --git a/assets/scripts/spec/index_spec.coffee b/assets/scripts/spec/index_spec.coffee index df96a419..6191f450 100644 --- a/assets/scripts/spec/index_spec.coffee +++ b/assets/scripts/spec/index_spec.coffee @@ -11,7 +11,7 @@ describe 'on the "index" state', -> ] displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysSummary type: 'build' diff --git a/assets/scripts/spec/job_spec.coffee b/assets/scripts/spec/job_spec.coffee index 5736ad8d..e335f3ab 100644 --- a/assets/scripts/spec/job_spec.coffee +++ b/assets/scripts/spec/job_spec.coffee @@ -21,7 +21,7 @@ describe 'on the "job" state', -> waits 100 runs -> displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysSummary id: 1 diff --git a/assets/scripts/spec/my_repos_spec.coffee b/assets/scripts/spec/my_repos_spec.coffee index 21afcd25..25873cd0 100644 --- a/assets/scripts/spec/my_repos_spec.coffee +++ b/assets/scripts/spec/my_repos_spec.coffee @@ -13,7 +13,7 @@ describe 'my repos tab', -> ] displaysRepository - href: 'http://github.com/travis-ci/travis-core' + href: '/travis-ci/travis-core' displaysSummary type: 'build' diff --git a/assets/scripts/spec/support/expectations.coffee b/assets/scripts/spec/support/expectations.coffee index 28034a59..c7d2021e 100644 --- a/assets/scripts/spec/support/expectations.coffee +++ b/assets/scripts/spec/support/expectations.coffee @@ -1,5 +1,6 @@ @displaysRepository = (repo) -> expect($('#repo h3 a').attr('href')).toEqual (repo.href) + expect($('#repo .github-icon a').attr('href')).toEqual ("https//github.com#{repo.href}") @displaysTabs = (tabs) -> for name, tab of tabs From d82116d68f8964d30255d0e919de37f7d01eb80a Mon Sep 17 00:00:00 2001 From: Mathias Meyer Date: Fri, 10 May 2013 17:09:40 +0200 Subject: [PATCH 3/3] Fix GitHub URL test. --- assets/scripts/spec/support/expectations.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/scripts/spec/support/expectations.coffee b/assets/scripts/spec/support/expectations.coffee index c7d2021e..757e80fa 100644 --- a/assets/scripts/spec/support/expectations.coffee +++ b/assets/scripts/spec/support/expectations.coffee @@ -1,6 +1,6 @@ @displaysRepository = (repo) -> expect($('#repo h3 a').attr('href')).toEqual (repo.href) - expect($('#repo .github-icon a').attr('href')).toEqual ("https//github.com#{repo.href}") + expect($('#repo .github-icon a').attr('href')).toEqual ("http://github.com#{repo.href}") @displaysTabs = (tabs) -> for name, tab of tabs