diff --git a/NOTES.txt b/NOTES.txt index 577dc5a8..1b2fc3b7 100644 --- a/NOTES.txt +++ b/NOTES.txt @@ -10,7 +10,7 @@ # Handlebars -* Can't {{bindAttr}} be just {{attr}}? Who cares it's "bound" in that context? +* Can't {{bind-attr}} be just {{attr}}? Who cares it's "bound" in that context? {{#each}} isn't {{#bindEach}} either. * Why is {{#collection contentBinding="foo"}} not just {{#collection foo}}? diff --git a/assets/scripts/app/templates/builds/list.hbs b/assets/scripts/app/templates/builds/list.hbs index 9e1baff4..51547030 100644 --- a/assets/scripts/app/templates/builds/list.hbs +++ b/assets/scripts/app/templates/builds/list.hbs @@ -35,7 +35,7 @@ {{{formatMessage commit.message short="true" repoBinding=build.repo}}} - + {{formatCommit commit}} @@ -44,15 +44,15 @@ {{#if view.isPullRequestsList}} - + #{{pullRequestNumber}} {{/if}} - + {{formatDuration duration}} - + {{formatTime finishedAt}} {{/view}} diff --git a/assets/scripts/app/templates/builds/show.hbs b/assets/scripts/app/templates/builds/show.hbs index 5096dd60..37f2f1f0 100644 --- a/assets/scripts/app/templates/builds/show.hbs +++ b/assets/scripts/app/templates/builds/show.hbs @@ -15,22 +15,22 @@
{{t builds.state}}
{{capitalize build.state}}
{{t builds.finished_at}}
-
{{formatTime build.finishedAt}}
+
{{formatTime build.finishedAt}}
{{t builds.duration}}
-
{{formatDuration build.duration}}
+
{{formatDuration build.duration}}
{{#with build}}
{{t builds.commit}}
-
{{formatCommit commit}}
+
{{formatCommit commit}}
{{#if pullRequest}}
{{t builds.pull_request}}
-
#{{pullRequestNumber}} {{pullRequestTitle}}
+
#{{pullRequestNumber}} {{pullRequestTitle}}
{{else}} {{#if commit.compareUrl}}
{{t builds.compare}}
-
{{pathFrom commit.compareUrl}}
+
{{pathFrom commit.compareUrl}}
{{/if}} {{/if}} {{#if commit.authorName}} diff --git a/assets/scripts/app/templates/jobs/list.hbs b/assets/scripts/app/templates/jobs/list.hbs index 4429a4d9..591d55ea 100644 --- a/assets/scripts/app/templates/jobs/list.hbs +++ b/assets/scripts/app/templates/jobs/list.hbs @@ -29,10 +29,10 @@ {{/if}} {{/if}} - + {{formatDuration duration}} - + {{formatTime finishedAt}} {{#each value in configValues}} diff --git a/assets/scripts/app/templates/jobs/pre.hbs b/assets/scripts/app/templates/jobs/pre.hbs index 457d9699..c3aee48e 100644 --- a/assets/scripts/app/templates/jobs/pre.hbs +++ b/assets/scripts/app/templates/jobs/pre.hbs @@ -17,14 +17,14 @@ {{#if view.job.sponsor.name}} {{/if}} {{#if view.limited}}

This log is too long to be displayed. Please reduce the verbosity of your - build or download the the raw log. + build or download the the raw log.

{{/if}}
diff --git a/assets/scripts/app/templates/jobs/show.hbs b/assets/scripts/app/templates/jobs/show.hbs index 0d8fa914..06051c7b 100644 --- a/assets/scripts/app/templates/jobs/show.hbs +++ b/assets/scripts/app/templates/jobs/show.hbs @@ -1,5 +1,5 @@ {{#if job.isLoaded}} -
+
Job
@@ -14,22 +14,22 @@
{{t jobs.state}}
{{capitalize job.state}}
{{t jobs.finished_at}}
-
{{formatTime job.finishedAt}}
+
{{formatTime job.finishedAt}}
{{t jobs.duration}}
-
{{formatDuration job.duration}}
+
{{formatDuration job.duration}}
{{#with job}}
{{t jobs.commit}}
-
{{formatCommit commit}}
+
{{formatCommit commit}}
{{#if build.pullRequest}}
{{t builds.pull_request}}
-
#{{build.pullRequestNumber}} {{build.pullRequestTitle}}
+
#{{build.pullRequestNumber}} {{build.pullRequestTitle}}
{{else}} {{#if commit.compareUrl}}
{{t jobs.compare}}
-
{{pathFrom commit.compareUrl}}
+
{{pathFrom commit.compareUrl}}
{{/if}} {{/if}} {{#if commit.authorName}} diff --git a/assets/scripts/app/templates/layouts/top.hbs b/assets/scripts/app/templates/layouts/top.hbs index e883d6aa..d7085cce 100644 --- a/assets/scripts/app/templates/layouts/top.hbs +++ b/assets/scripts/app/templates/layouts/top.hbs @@ -29,13 +29,13 @@
  • Travis CI for Private Repositories
  • -
  • +
  • {{#if signedOut}} {{t layouts.top.github_login}} {{/if}} {{#if signedIn}} - {{#linkTo "profile" class="signed-in"}}{{userName}}{{/linkTo}} + {{#linkTo "profile" class="signed-in"}}{{userName}}{{/linkTo}} {{/if}} {{#if signingIn}} {{t layouts.top.signing_in}} diff --git a/assets/scripts/app/templates/profile/accounts.hbs b/assets/scripts/app/templates/profile/accounts.hbs index 56f5610b..c58f4ae0 100644 --- a/assets/scripts/app/templates/profile/accounts.hbs +++ b/assets/scripts/app/templates/profile/accounts.hbs @@ -2,7 +2,7 @@

  • diff --git a/assets/scripts/app/templates/profile/tabs.hbs b/assets/scripts/app/templates/profile/tabs.hbs index 8f770575..9ded1ba0 100644 --- a/assets/scripts/app/templates/profile/tabs.hbs +++ b/assets/scripts/app/templates/profile/tabs.hbs @@ -1,5 +1,5 @@
      -
    • +
    • {{#with view.account}} {{#if login}} @@ -9,7 +9,7 @@
    • {{#if view.displayUser}} -
    • +
    • {{#linkTo "account.profile" view.account}}Profile{{/linkTo}}
      diff --git a/assets/scripts/app/templates/profile/tabs/hooks.hbs b/assets/scripts/app/templates/profile/tabs/hooks.hbs index dc920183..8aec75ac 100644 --- a/assets/scripts/app/templates/profile/tabs/hooks.hbs +++ b/assets/scripts/app/templates/profile/tabs/hooks.hbs @@ -17,13 +17,13 @@
        {{#each hook in hooks}} -
      • - {{hook.slug}} +
      • + {{hook.slug}} {{#if hook.isSaving}}{{/if}}

        {{hook.description}}

        - + {{#if hook.active}} ON @@ -54,8 +54,8 @@
          {{#each hook in unAdminisetableHooks}} -
        • - {{hook.slug}} +
        • + {{hook.slug}}

          {{hook.description}}

        • {{/each}} diff --git a/assets/scripts/app/templates/profile/tabs/user.hbs b/assets/scripts/app/templates/profile/tabs/user.hbs index b42239c8..d926d3f2 100644 --- a/assets/scripts/app/templates/profile/tabs/user.hbs +++ b/assets/scripts/app/templates/profile/tabs/user.hbs @@ -1,4 +1,4 @@ - +
          @@ -6,7 +6,7 @@ {{t profiles.show.github}}:
          - {{user.login}} + {{user.login}}
          diff --git a/assets/scripts/app/templates/queues/list.hbs b/assets/scripts/app/templates/queues/list.hbs index fe08ffd2..d781c586 100644 --- a/assets/scripts/app/templates/queues/list.hbs +++ b/assets/scripts/app/templates/queues/list.hbs @@ -2,7 +2,7 @@ {{#each queue in controller}}
        • {{t queue}}: {{queue.name}}

          -
            +
              {{#each job in queue}} {{#view Travis.QueueItemView jobBinding="job"}} {{#if job.repo.slug}} diff --git a/assets/scripts/app/templates/repos/list.hbs b/assets/scripts/app/templates/repos/list.hbs index 378891fc..ddbfe251 100644 --- a/assets/scripts/app/templates/repos/list.hbs +++ b/assets/scripts/app/templates/repos/list.hbs @@ -22,11 +22,11 @@

              {{t repositories.duration}}: - {{formatDuration lastBuildDuration}} + {{formatDuration lastBuildDuration}}

              {{t repositories.finished_at}}: - {{formatTime lastBuildFinishedAt}} + {{formatTime lastBuildFinishedAt}}

              diff --git a/assets/scripts/app/templates/repos/list/tabs.hbs b/assets/scripts/app/templates/repos/list/tabs.hbs index 3511bef4..04d03fa3 100644 --- a/assets/scripts/app/templates/repos/list/tabs.hbs +++ b/assets/scripts/app/templates/repos/list/tabs.hbs @@ -1,13 +1,13 @@ diff --git a/assets/scripts/app/templates/repos/show.hbs b/assets/scripts/app/templates/repos/show.hbs index 7d7d3cf7..5addbe79 100644 --- a/assets/scripts/app/templates/repos/show.hbs +++ b/assets/scripts/app/templates/repos/show.hbs @@ -1,4 +1,4 @@ -
              +
              {{#if view.isEmpty}} {{view Travis.ReposEmptyView}} {{else}} @@ -6,7 +6,7 @@ {{#with repo}}

              {{#linkTo "repo" this}}{{slug}}{{/linkTo}}

              -
              +
              {{view Travis.RepoShowToolsView}}
              diff --git a/assets/scripts/app/templates/repos/show/actions.hbs b/assets/scripts/app/templates/repos/show/actions.hbs index 181d23e6..362c9536 100644 --- a/assets/scripts/app/templates/repos/show/actions.hbs +++ b/assets/scripts/app/templates/repos/show/actions.hbs @@ -3,39 +3,39 @@ {{#if view.displayCancelBuild}}
            • + {{bind-attr class="view.canCancelBuild::disabled"}}>
            • {{/if}} {{#if view.displayCancelJob}}
            • + {{bind-attr class="view.canCancelJob::disabled"}}>
            • {{/if}} {{#if view.displayRequeueBuild}}
            • + {{bind-attr class="view.canRequeueBuild::disabled"}}>
            • {{/if}} {{#if view.displayRequeueJob}}
            • + {{bind-attr class="view.canRequeueJob::disabled"}}>
            • {{/if}} {{!TODO: for some reason showDownloadLog, which just delegates to jobIdForLog does not refresh 'if' properly, need further investigation}} {{#if view.jobIdForLog}}
            • - +
            • {{/if}} {{#if view.displayCodeClimate}}
            • + {{bind-attr class=":open-popup"}}>
            • diff --git a/assets/scripts/app/templates/repos/show/tabs.hbs b/assets/scripts/app/templates/repos/show/tabs.hbs index b1671c2f..2b3ef740 100644 --- a/assets/scripts/app/templates/repos/show/tabs.hbs +++ b/assets/scripts/app/templates/repos/show/tabs.hbs @@ -1,5 +1,5 @@
                -
              • +
              • {{#if repo.slug}} {{#linkTo "repo" repo currentWhen="repo.index"}} @@ -8,7 +8,7 @@ {{/if}}
              • -
              • +
              • {{#if repo.slug}} {{#linkTo "builds" repo}} @@ -17,7 +17,7 @@ {{/if}}
              • -
              • +
              • {{#if repo.slug}} {{#linkTo "pullRequests" repo}} @@ -26,7 +26,7 @@ {{/if}}
              • -
              • +
              • {{#if repo.slug}} {{#linkTo "branches" repo}} @@ -35,7 +35,7 @@ {{/if}}
              • -
              • +
              • {{#if build.id}} {{#if repo.slug}} @@ -46,7 +46,7 @@ {{/if}}
              • -
              • +
              • {{#if job.id}} {{#if repo.slug}} diff --git a/assets/scripts/app/templates/repos/show/tools.hbs b/assets/scripts/app/templates/repos/show/tools.hbs index f6368253..5cc706df 100644 --- a/assets/scripts/app/templates/repos/show/tools.hbs +++ b/assets/scripts/app/templates/repos/show/tools.hbs @@ -6,7 +6,7 @@
              • + {{bind-attr class=":open-popup view.canRegenerateKey::disabled"}}> Regenerate Key
              • @@ -14,7 +14,7 @@
              {{#if view.displayStatusImages}} - + {{/if}} @@ -58,7 +58,7 @@

              Integrating Code Climate's test coverage reporting with your test suite on Travis CI allows to track changes in coverage over time. If you haven't tried it out already, sign + {{bind-attr href="Travis.config.code_climate_url"}}" target="_blank">sign up today to improve your code's quality. New customers get 20% off for the first three months!

              diff --git a/assets/scripts/app/templates/status_images.hbs b/assets/scripts/app/templates/status_images.hbs index f5dc5c0a..0f832f2b 100644 --- a/assets/scripts/app/templates/status_images.hbs +++ b/assets/scripts/app/templates/status_images.hbs @@ -9,25 +9,25 @@

              - +

              - +

              - +

              - +

              - +

              - +

              diff --git a/assets/scripts/app/views/repo/show.coffee b/assets/scripts/app/views/repo/show.coffee index a27a0b29..5deaf914 100644 --- a/assets/scripts/app/views/repo/show.coffee +++ b/assets/scripts/app/views/repo/show.coffee @@ -37,7 +37,7 @@ Travis.reopen tabBinding: 'controller.tab' contextBinding: 'controller' - # hrm. how to parametrize bindAttr? + # hrm. how to parametrize bind-attr? classCurrent: (-> 'active' if @get('tab') == 'current' ).property('tab') diff --git a/assets/scripts/app/views/top.coffee b/assets/scripts/app/views/top.coffee index ac9e8d24..fe5d7aea 100644 --- a/assets/scripts/app/views/top.coffee +++ b/assets/scripts/app/views/top.coffee @@ -4,7 +4,7 @@ tabBinding: 'controller.tab' - # hrm. how to parametrize bindAttr? + # hrm. how to parametrize bind-attr? classHome: (-> 'active' if @get('tab') == 'home' ).property('tab')