From cc1df672721438da39af56b6a01dc7e91b08a95c Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Tue, 6 Nov 2012 19:26:42 +0100 Subject: [PATCH] We don't need to check isComplete now We load records based on the tries to load attributes that are not loaded yet, so isComplete is obsolete now. --- assets/scripts/app/templates/jobs/show.hbs | 2 +- assets/scripts/app/templates/repos/show.hbs | 2 +- assets/scripts/app/views/repo/show.coffee | 8 ++------ 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/assets/scripts/app/templates/jobs/show.hbs b/assets/scripts/app/templates/jobs/show.hbs index 57ef426d..5dd669e6 100644 --- a/assets/scripts/app/templates/jobs/show.hbs +++ b/assets/scripts/app/templates/jobs/show.hbs @@ -1,5 +1,5 @@ {{#with view}} - {{#if job.isComplete}} + {{#if job.isLoaded}}
diff --git a/assets/scripts/app/templates/repos/show.hbs b/assets/scripts/app/templates/repos/show.hbs index 8eec166e..b01e0dec 100644 --- a/assets/scripts/app/templates/repos/show.hbs +++ b/assets/scripts/app/templates/repos/show.hbs @@ -2,7 +2,7 @@ {{#if view.isEmpty}} {{view Travis.ReposEmptyView}} {{else}} - {{#if view.repo.isComplete}} + {{#if view.repo.isLoaded}} {{#with view.repo}}

{{slug}} diff --git a/assets/scripts/app/views/repo/show.coffee b/assets/scripts/app/views/repo/show.coffee index fd02615b..36d20c13 100644 --- a/assets/scripts/app/views/repo/show.coffee +++ b/assets/scripts/app/views/repo/show.coffee @@ -6,12 +6,8 @@ repoBinding: 'controller.repo' class: (-> - 'loading' if !@get('repo.isComplete') && !@get('isEmpty') - ).property('repo.isComplete') - - isEmpty: (-> - @get('repos.isLoaded') && @get('repos.length') == 0 - ).property('repos.length') + 'loading' unless @get('repo.isLoaded') + ).property('repo.isLoaded') urlGithub: (-> Travis.Urls.githubRepo(@get('repo.slug'))