From ce3ef8f7d293e84bb159f9cbb218cedc8345326f Mon Sep 17 00:00:00 2001 From: Justine Arreche Date: Tue, 9 Dec 2014 09:49:59 +0100 Subject: [PATCH] fixed line-height issue in Chrome and Firefox --- assets/scripts/app/templates/builds/show.hbs | 6 ++-- assets/styles/main/summary.sass | 33 +++----------------- 2 files changed, 8 insertions(+), 31 deletions(-) diff --git a/assets/scripts/app/templates/builds/show.hbs b/assets/scripts/app/templates/builds/show.hbs index 02d33aba..21e3a2be 100644 --- a/assets/scripts/app/templates/builds/show.hbs +++ b/assets/scripts/app/templates/builds/show.hbs @@ -27,14 +27,14 @@ {{/if}}
- + Commit {{formatSha commit.sha}}
{{#if build.pullRequest}} - + #{{build.pullRequestNumber}}: {{build.pullRequestTitle}} {{else}} {{#if build.commit.compareUrl}} - + Compare {{shortCompareShas build.commit.compareUrl}} {{/if}} {{/if}}
diff --git a/assets/styles/main/summary.sass b/assets/styles/main/summary.sass index bb9565ad..7274e491 100644 --- a/assets/styles/main/summary.sass +++ b/assets/styles/main/summary.sass @@ -96,40 +96,16 @@ font-size: 13px display: block width: 100% + height: 20px text-align: left - line-height: 23px - margin-left: 12px - - .commit-changes - text-align: left - text-decoration: underline - width: inherit - - div - display: inline - clear: none - - a - text-overflow: ellipsis - white-space: nowrap - overflow: hidden - display: inline-block - max-width: 175px - - .commit-changes - background: inline-image('icons/github.svg') left center no-repeat - background-size: 13px 13px - text-align: left - text-decoration: underline - width: inherit - font-size: 13px - margin-left: 12px - padding-left: 20px line-height: 20px + margin-left: 12px + .commit-changes div display: inline clear: none + height: 20px a text-overflow: ellipsis @@ -137,6 +113,7 @@ overflow: hidden display: inline-block max-width: 175px + line-height: 20px .right margin-top: 10px