From d3b13d82385f44eab286a1892e5a89a02cde6c2d Mon Sep 17 00:00:00 2001 From: Mathias Meyer Date: Tue, 17 Jun 2014 17:32:33 +0200 Subject: [PATCH] Mark invalid concurrent setting input properly. This adds a CSS class if the content is invalid. --- assets/scripts/app/controllers.coffee | 3 ++- assets/scripts/app/templates/repo/settings.hbs | 2 +- assets/styles/settings.sass | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/assets/scripts/app/controllers.coffee b/assets/scripts/app/controllers.coffee index 68232ffe..ad07c187 100644 --- a/assets/scripts/app/controllers.coffee +++ b/assets/scripts/app/controllers.coffee @@ -58,10 +58,11 @@ Travis.RepoSettingsController = Em.ObjectController.extend settingsChanged: (-> if parseInt(@get('settings.maximum_number_of_builds')) > 0 + @set('settings.maximum_number_of_builds_valid', '') @get('model').saveSettings(@get('settings')).then null, -> Travis.flash(error: 'There was an error while saving settings. Please try again.') else - Travis.flash(error: 'The maximum number of concurrent builds needs to be a number greater than zero.') + @set('settings.maximum_number_of_builds_valid', 'invalid') ).observes('settings.maximum_number_of_builds') save: -> diff --git a/assets/scripts/app/templates/repo/settings.hbs b/assets/scripts/app/templates/repo/settings.hbs index 4c87de04..eacaafc1 100644 --- a/assets/scripts/app/templates/repo/settings.hbs +++ b/assets/scripts/app/templates/repo/settings.hbs @@ -34,7 +34,7 @@
-
+
{{input value=settings.maximum_number_of_builds size="4" pattern='/^[0-9]+$/'}}