From f123162627c37dc3288c418c067876147989ab83 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Tue, 18 Feb 2014 10:10:25 +0100 Subject: [PATCH] Use Em.computed.sort and Em.computed.limit instead of nesting proxies With new array computed helpers we can simplify code and get rid of nested array proxies. --- assets/scripts/app/controllers/repos.coffee | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/assets/scripts/app/controllers/repos.coffee b/assets/scripts/app/controllers/repos.coffee index f61de1a4..0a3cf28c 100644 --- a/assets/scripts/app/controllers/repos.coffee +++ b/assets/scripts/app/controllers/repos.coffee @@ -36,13 +36,14 @@ Travis.ReposController = Ember.ArrayController.extend Visibility.every Travis.INTERVALS.updateTimes, @updateTimes.bind(this) recentRepos: (-> - Travis.LimitedArray.create - content: Em.ArrayProxy.extend(Em.SortableMixin).create( - sortProperties: ['sortOrder'] - content: Travis.Repo.withLastBuild() - isLoadedBinding: 'content.isLoaded' - ) + Ember.ArrayProxy.extend( + isLoadedBinding: 'repos.isLoaded' + repos: Travis.Repo.withLastBuild() + sorted: Ember.computed.sort('repos', 'sortedReposKeys') + content: Ember.computed.limit('sorted', 'limit') + sortedReposKeys: ['sortOrder:asc'] limit: 30 + ).create() ).property() updateTimes: ->