From fbcfa048590373864a8ca1bb7ae6e2310202ef9f Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Tue, 30 Dec 2014 11:58:56 +0100 Subject: [PATCH] Don't destroy parts on cleanup Destroying parts on cleanup can have weird effects, because we observe parts in log view. --- assets/scripts/app/models/log.coffee | 3 +-- assets/scripts/app/views/log.coffee | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/scripts/app/models/log.coffee b/assets/scripts/app/models/log.coffee index b42cb75c..6056731f 100644 --- a/assets/scripts/app/models/log.coffee +++ b/assets/scripts/app/models/log.coffee @@ -33,8 +33,7 @@ require 'travis/log_chunks' clearParts: -> parts = @get('parts') - @notifyPropertyChange('parts') - parts.destroy() + parts.set('content', []) fetch: -> console.log 'log model: fetching log' if Log.DEBUG diff --git a/assets/scripts/app/views/log.coffee b/assets/scripts/app/views/log.coffee index b1646fe9..e6ac4a99 100644 --- a/assets/scripts/app/views/log.coffee +++ b/assets/scripts/app/views/log.coffee @@ -68,6 +68,7 @@ Travis.reopen parts = log.get('parts') parts.removeArrayObserver(@, didChange: 'partsDidChange', willChange: 'noop') parts.destroy() + log.notifyPropertyChange('parts') @lineSelector?.willDestroy() createEngine: ->