From fedc6acec1abcf078114c710bbca04b65163c657 Mon Sep 17 00:00:00 2001 From: Lisa P Date: Tue, 6 Oct 2015 00:54:08 +0200 Subject: [PATCH] take out dropup on build tiles and use title attribtue instead --- app/components/build-tile.coffee | 6 ++++++ app/styles/app/layouts/branches.sass | 2 +- app/templates/components/build-tile.hbs | 8 ++++---- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/app/components/build-tile.coffee b/app/components/build-tile.coffee index cd2d79ae..f0ee48ab 100644 --- a/app/components/build-tile.coffee +++ b/app/components/build-tile.coffee @@ -4,5 +4,11 @@ BuildTileComponent = Ember.Component.extend tagName: 'li' classNameBindings: ['build.state'] + attributeBindings: ['title'], + + title: (-> + num = @get('build.number') + "##{num}" + ).property('build') `export default BuildTileComponent` diff --git a/app/styles/app/layouts/branches.sass b/app/styles/app/layouts/branches.sass index bea1173b..1b7969a4 100644 --- a/app/styles/app/layouts/branches.sass +++ b/app/styles/app/layouts/branches.sass @@ -141,6 +141,7 @@ .dropup--status @extend %dropup + left: 0 right: 0 margin: auto display: none @@ -152,7 +153,6 @@ margin-right: 0 @media #{$medium-up} top: -2.3em - width: 5em padding: .1em .1em white-space: nowrap font-size: 14px; diff --git a/app/templates/components/build-tile.hbs b/app/templates/components/build-tile.hbs index 62fe2f83..acd6fbdd 100644 --- a/app/templates/components/build-tile.hbs +++ b/app/templates/components/build-tile.hbs @@ -1,10 +1,10 @@ {{#if build.number}} - {{#link-to "build" build.repository build.id class="dropup-trigger"}} + {{#link-to "build" build.repository.slug build.id}} {{status-icon status=build.state}} {{build.last_build.state}} -
+ {{!--
{{request-icon build=build}} #{{build.number}} -
+
--}} {{/link-to}} -{{/if}} \ No newline at end of file +{{/if}}