Commit Graph

7 Commits

Author SHA1 Message Date
Curtis Ekstrom
142a7217d4
Remove *Binding(s) from project
These bindings can be replaced wholesale with the more idiomatic
alternative: aliases.

In addition, avoid passing in user to components where it can be injected directly.

One of the perceived downsides of dependency injection can be
that it can make debugging feel more difficult because it's not
immediately clear where the value is coming from, which the explicit
variant we previously used does not suffer from. It might also be
argued that we also lose out on a seam that could be useful in the
future where a component doesn't care about the specific type of
user, just that one is passed in.

While explicitness is often a virtue, it comes at the cost of increased
noise that pervades multiple layers of components. I'd argue this makes
the parent components more difficult to understand, given they are
littered with unnecessary references to data they themselves do not
need.

This decreases the noise/ceremony around accessing
userPermissions/auth data and restricts access to that data to
the child components that actually need to know about it.

As to losing a seam, it appears 1) that this isn't
currently necessary and 2) we can use an internal computed
property should the need arise in the future.
2016-04-13 13:54:51 +02:00
Piotr Sarnacki
6efb2ac449 No need to load builds into repo.builds
Builds on repo model already incorporate all of the builds that belong
to a given repo and are loaded into a store, so no need to load them to
expandable array.
2016-01-18 13:18:19 +01:00
Piotr Sarnacki
c70ed06848 Fix sorting on builds list 2016-01-14 15:40:06 +01:00
Piotr Sarnacki
557797ab19 Fix show more button for builds
While doing search and replace I accidentally replaced too much
occurences of 'builds'
2016-01-14 14:10:20 +01:00
Piotr Sarnacki
271b8f89ea Fix show more button and simplify builds controller 2016-01-13 11:25:41 +01:00
Piotr Sarnacki
39cf0b3044 [deprecations] Don't use ArrayController 2016-01-07 11:22:40 +01:00
Piotr Sarnacki
fafaf65043 Convert project to JavaScript 2016-01-04 13:15:14 +01:00