The problem with running jobs list was that it didn't show jobs that went to the
worker. The result was a confusing UI - when you look at the running jobs list
you want to know how many concurrent jobs you are using, including jobs that are
still waiting for a VM to boot.
This part needs further refactoring, but for now I just fixed log view to
teardown and setup things properly in all cases something changes (when element
is inserted or removed, but also when log object is changed).
This makes the timeline ordering odd when restarting: The repo will be
sorted to be bottom of the timeline while in :created state, and then
pops back up to the top when :started.
One weird thing is that it only seems to behave this way on com
(staging) and enterprise, but not on org (staging).
This reverts commit ce8237b4e7.
Because of our partial loading implementation we need to specify
finishedAt and startedAt differently than we would normally do. For some
reason duration was not recalculated while loading record and specifying
raw attributes helps here.
Duration on job was not specified, beacuse we actually don't return
duration from the API, it's always calculated based on startedAt and
finishedAt, that's why it's obsolete. It doesn't hurt to have it defined
on the Job model, but there's no need to do it.
* duration was not actually defined in Travis.Job, which may have caused
bugs when combined with partial record loading (so for example it was
ok on a refresh, but may have been broken on update)
* notStarted was not a dependency of duration
We no longer need this check, because it was only relevant with Ember
Data. Additionally it was a cause of a travis-ci/travis-ci#1992, because
of wrong syntax:
unless someFunction false or true
will only check for a result of someFunction with an argument being the
result of `or` expression.
I found the commit that caused the bug that caused me to do the last
revert. I'm therefore reverting the previous revert and I will be
committing a revert that reverts the commit that introduced the bug. See
next commit.
This reverts commit db2d38a7af.
