Our ajax function was passing params as object to xhr.send function.
For some reason this breaks on Firefox 34.0 beta. Sending stringified
version of params works correctly.
After upgrading ember to 1.8.1 tests pass, but I found a few cases where
things break (for example when navigating between certain routes). I'm
reverting for now.
This reverts commit fa5e9179af, reversing
changes made to 978c887123.
We have a bug that results in sending unneeded ajax queries on missing
log parts. I'm working on a fix, but it may take a while, because I want
to refactor a few parts of the app instead of putting more hacks on
legacy code. To help with the situation I'm increasing timeout for
pusher fallback.
* Add `travis.source_endpoint` meta (fixes many tests with hard
expectations on `http://github.com` being in URL paths).
* Wrap `Ember.run.once` in a `Ember.run` (prevents test auto-run
assertion).
* Fix expect counts for a couple tests.
When changing adapter to make it work with env vars I used PATCH method.
Hooks are using PUT to update active fields, so it broke hooks. This
commit moves saveRecord with PATCH to env vars' adapter.
For some cases (like coming env vars) we will need to also pass a
repository id to the URL, so I'm passing it from createRecord and other
methods which handle records.
arrayComputed was added recently in order to make array computations
easier. Using arrayComputed we can improve LimitedArray which now uses
an isolated multipurpose Ember.computed.limit.
I found the commit that caused the bug that caused me to do the last
revert. I'm therefore reverting the previous revert and I will be
committing a revert that reverts the commit that introduced the bug. See
next commit.
This reverts commit db2d38a7af.
It seems that directly setting location.hash directly doesn't play nice
with Ember.js URL handling - using it to handle line numbers results in
weird bugs (URL stops being updated after setting hash manually).
This commit gets back to using window.history.pushState() which was
changed to direct hash manipulation in ff1aad3
This commit contains a settings pane implementation. There are a couple
of things here, which are not used yet, like advanced form helpers. I'm
leaving them here, because the plan is to add support for more settings
soon (like: include/exclude branch patterns), which will need these
helpers.
There is also tabs support, although in the current version there is
only one tab (initially it was created for supporting general tab and
notifications tab).
fetch method returns a promise instead of an actual object. We used find
before, because this was the way we did things before upgrade to Ember
Model. Returning a promise from a model hook pauses router rendering for
the time a resource is loading, which makes it much easier to deal with
asynchronous requests. Thanks to that we can remove parts of the code,
which dealt with it manually.
Ember Model does not do it automatically. I had a patch, which was
changing that, but after giving it more thought, I think it's not a good
idea - this should be up to adapter if the records are going into
record arrays.
When adding records just after loading them, the elements in the UI
might have to be updated, which may trigger `get` on associations right
away. As an effect, even if we load a few records on an event (like
repository on build:started event), ember model may end up fetching the
record.
This commit fixes such occurrences by adding record to record arrays in
a run loop, so newly created records will be added at once, after the
event was served.
Previousy I was using find to ensure that the record is materialized,
but the new version is much lighter - it uses Model#load to load the
record directly
