travis-web/app/controllers
Curtis Ekstrom 142a7217d4
Remove *Binding(s) from project
These bindings can be replaced wholesale with the more idiomatic
alternative: aliases.

In addition, avoid passing in user to components where it can be injected directly.

One of the perceived downsides of dependency injection can be
that it can make debugging feel more difficult because it's not
immediately clear where the value is coming from, which the explicit
variant we previously used does not suffer from. It might also be
argued that we also lose out on a seam that could be useful in the
future where a component doesn't care about the specific type of
user, just that one is passed in.

While explicitness is often a virtue, it comes at the cost of increased
noise that pervades multiple layers of components. I'd argue this makes
the parent components more difficult to understand, given they are
littered with unnecessary references to data they themselves do not
need.

This decreases the noise/ceremony around accessing
userPermissions/auth data and restricts access to that data to
the child components that actually need to know about it.

As to losing a seam, it appears 1) that this isn't
currently necessary and 2) we can use an internal computed
property should the need arise in the future.
2016-04-13 13:54:51 +02:00
..
accounts Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
dashboard Convert project to JavaScript 2016-01-04 13:15:14 +01:00
main Convert project to JavaScript 2016-01-04 13:15:14 +01:00
owner Convert project to JavaScript 2016-01-04 13:15:14 +01:00
.gitkeep Add ember-cli version of the Ember.js app 2015-02-03 09:48:22 +01:00
account.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
accounts.js [deprecations] Don't use ArrayController 2016-01-07 11:22:40 +01:00
auth.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
branches.js Fix mixin typo 2016-02-25 14:51:31 +01:00
build.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
builds.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
caches.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
current-user.js Fix jshint errors after conversion to JS 2016-01-04 13:15:15 +01:00
error.js [deprecations] Remove all of the views we use just for layouts 2016-01-12 16:55:22 +01:00
first-sync.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
flash.js Fix flash messages 2015-09-09 10:36:12 +02:00
home-pro.js Run GA instructions only if gaCode is set 2016-01-14 11:38:46 +01:00
home.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
job.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
loading.js [deprecations] Remove all of the views we use just for layouts 2016-01-12 16:55:22 +01:00
owner.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
plans.js Fix tests 2016-01-14 13:14:45 +01:00
profile.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
repo.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
repos.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
requests.js [deprecations] Don't use ArrayController 2016-01-07 11:22:40 +01:00
settings.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
top.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00