142a7217d4
These bindings can be replaced wholesale with the more idiomatic alternative: aliases. In addition, avoid passing in user to components where it can be injected directly. One of the perceived downsides of dependency injection can be that it can make debugging feel more difficult because it's not immediately clear where the value is coming from, which the explicit variant we previously used does not suffer from. It might also be argued that we also lose out on a seam that could be useful in the future where a component doesn't care about the specific type of user, just that one is passed in. While explicitness is often a virtue, it comes at the cost of increased noise that pervades multiple layers of components. I'd argue this makes the parent components more difficult to understand, given they are littered with unnecessary references to data they themselves do not need. This decreases the noise/ceremony around accessing userPermissions/auth data and restricts access to that data to the child components that actually need to know about it. As to losing a seam, it appears 1) that this isn't currently necessary and 2) we can use an internal computed property should the need arise in the future.
87 lines
2.3 KiB
JavaScript
87 lines
2.3 KiB
JavaScript
import { test, moduleForComponent } from 'ember-qunit';
|
|
import Ember from 'ember';
|
|
|
|
let userStub = Ember.Object.extend({
|
|
hasAccessToRepo: function(repo) {
|
|
ok(repo.get('id', 44));
|
|
ok(true, 'hasAccessToRepo was called');
|
|
return false;
|
|
}
|
|
}).create();
|
|
|
|
// stub auth service
|
|
const authStub = Ember.Service.extend({
|
|
currentUser: userStub
|
|
});
|
|
|
|
moduleForComponent('job-repo-actions', 'JobRepoActionsComponent', {
|
|
unit: true,
|
|
beforeEach() {
|
|
this.register('service:auth', authStub);
|
|
}
|
|
});
|
|
|
|
test('it shows cancel button if canCancel is true', function() {
|
|
var component;
|
|
component = this.subject({
|
|
canCancel: true
|
|
});
|
|
this.render();
|
|
return ok(component.$('a[title="Cancel job"]').length, 'cancel link should be visible');
|
|
});
|
|
|
|
test('it shows restart button if canRestart is true', function() {
|
|
var component;
|
|
component = this.subject({
|
|
canRestart: true
|
|
});
|
|
this.render();
|
|
return ok(component.$('a[title="Restart job"]').length, 'restart link should be visible');
|
|
});
|
|
|
|
test('user can cancel if she has permissions to a repo and job is cancelable', function() {
|
|
var component, job;
|
|
job = Ember.Object.create({
|
|
canCancel: false,
|
|
userHasPermissionForRepo: true
|
|
});
|
|
component = this.subject({
|
|
job: job,
|
|
userHasPermissionForRepo: false
|
|
});
|
|
ok(!component.get('canCancel'));
|
|
component.set('userHasPermissionForRepo', true);
|
|
ok(!component.get('canCancel'));
|
|
job.set('canCancel', true);
|
|
return ok(component.get('canCancel'));
|
|
});
|
|
|
|
test('user can restart if she has permissions to a repo and job is restartable', function() {
|
|
var component, job;
|
|
job = Ember.Object.create({
|
|
canRestart: false,
|
|
userHasPermissionForRepo: true
|
|
});
|
|
component = this.subject({
|
|
job: job,
|
|
userHasPermissionForRepo: false
|
|
});
|
|
ok(!component.get('canRestart'));
|
|
component.set('userHasPermissionForRepo', true);
|
|
ok(!component.get('canRestart'));
|
|
job.set('canRestart', true);
|
|
return ok(component.get('canRestart'));
|
|
});
|
|
|
|
test('it properly checks for user permissions for a repo', function() {
|
|
var component, repo, user;
|
|
expect(3);
|
|
repo = Ember.Object.create({
|
|
id: 44
|
|
});
|
|
component = this.subject({
|
|
repo: repo
|
|
});
|
|
return ok(!component.get('userHasPermissionForRepo'), 'user should not have access to a repo');
|
|
});
|