suzanne.soy/type-expander
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

change polymorphic types to type constructors #13

Merged
capfredf merged 1 commits from fix-types into main 2021-11-11 09:24:56 +00:00
Conversation 4 Commits 1 Files Changed 1 +56 -57
capfredf commented 2021-11-05 17:39:33 +00:00 (Migrated from github.com)
Copy Link

this fix ensured the code to be forward compatible with
the upcoming TR's kind system

this fix ensured the code to be forward compatible with the upcoming TR's [kind system](https://github.com/racket/typed-racket/pull/1143)
SuzanneSoy commented 2021-11-06 12:11:59 +00:00 (Migrated from github.com)
Copy Link

Hi, thanks for the patch!

IIUC, only the define-type in the tests needed to be updated? There's a lot of noise in the diff due to a whitespace change, just checking that I didn't miss anything :)

Kinds are exciting! Thanks for having worked on those for TR :)

Hi, thanks for the patch! IIUC, only the define-type in the tests needed to be updated? There's a lot of noise in the diff due to a whitespace change, just checking that I didn't miss anything :) Kinds are exciting! Thanks for having worked on those for TR :)
capfredf commented 2021-11-08 03:25:24 +00:00 (Migrated from github.com)
Copy Link

Sorry about the noise. I thought white space changes could be easily ignored via (?w=1 or git diff -w). I'll revert those white space changes.

I used raco test -p type-expander to test the changed type-expander against the working TR branch and all tests passed.

Do you have anything particular in mind that I need to test?

Sorry about the noise. I thought white space changes could be easily ignored via ([?w=1](https://github.com/SuzanneSoy/type-expander/pull/13/files?w=1) or `git diff -w`). I'll revert those white space changes. I used `raco test -p type-expander` to test the changed `type-expander` against the working TR branch and all tests passed. Do you have anything particular in mind that I need to test?
SuzanneSoy commented 2021-11-08 08:57:37 +00:00 (Migrated from github.com)
Copy Link

Oooh, I never knew about ?w=1, that's a great trick! No need to revert the changes, don't worry.

I think raco test -p type-expander should be enough, I used to have a CI script but it suspect it won't work anymore since Travis changed things on their platform; I'll disable the checks and merge in a couple of hours.

Oooh, I never knew about ?w=1, that's a great trick! No need to revert the changes, don't worry. I think `raco test -p type-expander` should be enough, I used to have a CI script but it suspect it won't work anymore since Travis changed things on their platform; I'll disable the checks and merge in a couple of hours.
SuzanneSoy commented 2021-11-11 09:25:35 +00:00 (Migrated from github.com)
Copy Link

Sorry about the delay, merged. Thanks a lot for the fix :) !

Sorry about the delay, merged. Thanks a lot for the fix :) !
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suzanne.soy/type-expander#13
No description provided.
Delete Branch "fix-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?