suzanne.soy/typed-racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve error for applying vals of Procedure type

Browse Source 
original commit: 6629c999d180b9af217501db79adaf0208c7b160
This commit is contained in:
Asumu Takikawa 2014-07-01 18:16:21 -04:00
parent 1ff78cbce4
commit 5f3ed34764
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/tc-app-helper.rkt
View File

@ -105,8 +105,11 @@
(if tail-bound (cons tail-ty tail-bound) #f)))
(cond
[(null? doms)
(tc-error/expr "cannot apply function of type Procedure"
#:return return)]
(tc-error/expr/fields
"cannot apply a function with unknown arity"
#:more (format "~a has type Procedure which cannot be applied"
(name->function-str (and (identifier? f-stx) f-stx)))
#:return return)]
[(and (= 1 (length doms)) (not (car rests)) (not (car drests)) (not tail-ty) (not tail-bound))
(tc-error/expr
#:return return
@ -332,9 +335,7 @@
(PolyRow-names:
msg-vars _
(Function/arrs: msg-doms msg-rngs msg-rests msg-drests (list (Keyword: _ _ #f) ...))))
(let ([fcn-string (if name
(format "function `~a'" (syntax->datum name))
"function")])
(let ([fcn-string (name->function-str name)])
(if (and (andmap null? msg-doms)
(null? argtypes))
(tc-error/expr (string-append
@ -374,3 +375,9 @@
(string-append "Type Variables: " (stringify msg-vars) "\n")
""))))))]))
;; name->function-str : (Option Identifier) -> String
;; Produce a function name string for error messages
(define (name->function-str name)
(if name
(format "function `~a'" (syntax->datum name))
"function"))

2
pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/typecheck-tests.rkt
View File

@ -3113,7 +3113,7 @@
(: f Procedure)
(define f (lambda () 'hi))
(f))
#:msg "cannot apply function of type Procedure"]
#:msg "function with unknown arity"]
;; PR 13259
[tc-err