suzanne.soy/typed-racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Give more information for kw errors in TR

Browse Source 
Tells the user which missing keywords were mandatory and
which were optional (which is useful if, e.g., the expected type
says mandatory but the function had it optional).

original commit: 8b53d32f5231f94677e1088b940e92a71ed1e311
This commit is contained in:
Asumu Takikawa 2014-06-20 12:21:45 -04:00
parent 6c0da3e041
commit 9052bb40a2
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/types/kw-types.rkt
View File

@ -264,17 +264,20 @@
(define-values (mand-kw-types opt-kw-types) (partition-kws kws))
(define mand-kws (map Keyword-kw mand-kw-types))
(define opt-kws (map Keyword-kw opt-kw-types))
(define missing-kws (set-union (set-subtract mand-kws actual-mands)
(set-subtract opt-kws actual-opts)))
(define missing-opts (set-subtract opt-kws actual-opts))
(define missing-mands (set-subtract mand-kws actual-mands))
;; extra optional keywords are okay
(define extra-kws (set-subtract actual-mands mand-kws))
(unless (set-empty? missing-kws)
(unless (and (set-empty? missing-mands)
(set-empty? missing-opts))
(tc-error/fields
#:delayed? #t
"type mismatch"
#:more "function is missing keyword arguments"
"missing keywords"
(string-join (map ~a missing-kws))
"missing mandatory keywords"
(string-join (map ~a missing-mands))
"missing optional keywords"
(string-join (map ~a missing-opts))
"expected type" f-type))
(unless (set-empty? extra-kws)
(tc-error/fields